[GitHub] joshwalters commented on a change in pull request #3473: Feature: Paired t-test table visualization

[gi...@git.apache.org]

joshwalters commented on a change in pull request #3473: Feature: Paired t-test table visualization
URL: https://github.com/apache/incubator-superset/pull/3473#discussion_r139831165
 
 

 ##########
 File path: superset/assets/visualizations/paired_ttest.jsx
 ##########
 @@ -0,0 +1,266 @@
+import d3 from 'd3';
+import dist from 'distributions';
+
+import React from 'react';
+import { Table, Tr, Td, Thead, Th } from 'reactable';
+import ReactDOM from 'react-dom';
+import PropTypes from 'prop-types';
+
+import './paired_ttest.css';
+
+class TTestTable extends React.Component {
+
+  constructor(props) {
+    super(props);
+    this.state = {
+      pValues: [],
+      liftValues: [],
+      control: 0,
+    };
+  }
+
+  componentWillMount() {
+    this.computeTTest(this.state.control);
+  }
+
+  getLiftStatus(row) {
 
 Review comment:
   Could you add some code comments on some of these functions? I get the general idea of what the functions do, but some comments might help with future clarity.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services