You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/04/01 10:21:23 UTC
[GitHub] [incubator-superset] codecov-io commented on issue #7142: [SQL Lab] Introduced ALLOW_SQL_MAX_ROW_OVERRIDE config to allow users…
codecov-io commented on issue #7142: [SQL Lab] Introduced ALLOW_SQL_MAX_ROW_OVERRIDE config to allow users…
URL: https://github.com/apache/incubator-superset/pull/7142#issuecomment-478522632
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7142?src=pr&el=h1) Report
> Merging [#7142](https://codecov.io/gh/apache/incubator-superset/pull/7142?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/03c95c86ddac7f7210df178ff20c2b6369875298?src=pr&el=desc) will **increase** coverage by `<.01%`.
> The diff coverage is `83.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/7142?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7142 +/- ##
==========================================
+ Coverage 64.64% 64.64% +<.01%
==========================================
Files 422 422
Lines 20610 20618 +8
Branches 2253 2256 +3
==========================================
+ Hits 13323 13329 +6
- Misses 7165 7167 +2
Partials 122 122
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7142?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/assets/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/7142/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvcmVkdWNlcnMvc3FsTGFiLmpz) | `56.6% <ø> (ø)` | :arrow_up: |
| [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/7142/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `69.1% <ø> (ø)` | :arrow_up: |
| [.../assets/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7142/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9UYWJiZWRTcWxFZGl0b3JzLmpzeA==) | `83.33% <ø> (ø)` | :arrow_up: |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/7142/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `76.75% <100%> (+0.12%)` | :arrow_up: |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/7142/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `93.78% <100%> (+0.03%)` | :arrow_up: |
| [...uperset/assets/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7142/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9TcWxFZGl0b3IuanN4) | `59.8% <75%> (-0.2%)` | :arrow_down: |
| [...rset/assets/src/SqlLab/components/LimitControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7142/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9MaW1pdENvbnRyb2wuanN4) | `89.47% <80%> (-1.71%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7142?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7142?src=pr&el=footer). Last update [03c95c8...6c63f7e](https://codecov.io/gh/apache/incubator-superset/pull/7142?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org