You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by arunmahadevan <gi...@git.apache.org> on 2017/01/11 06:59:48 UTC
[GitHub] storm pull request #1872: [STORM-2283] Fix multi threading issues in Default...
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/1872
[STORM-2283] Fix multi threading issues in DefaultStateSerializer
Raising a separate patch for the state issue fixed in https://github.com/apache/storm/pull/1693
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm STORM-2283
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/1872.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1872
----
commit 75f50acc5829684c2bd799d0a9d71c5f34de5447
Author: Arun Mahadevan <ar...@apache.org>
Date: 2017-01-11T06:48:31Z
[STORM-2283] Fix multi threading issues in DefaultStateSerializer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1872: [STORM-2283] Fix multi threading issues in DefaultStateSe...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1872
+1 Thanks for the quick fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1872: [STORM-2283] Fix multi threading issues in DefaultStateSe...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1872
+1 Confirmed this works well from #1693.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1872: [STORM-2283] Fix multi threading issues in DefaultStateSe...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1872
@HeartSaVioR guava's Optional did not have a public default ctor and Kryo was throwing errors during deserialization. I will try to address it and raise a different patch for 1.x branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1872: [STORM-2283] Fix multi threading issues in DefaultStateSe...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/1872
@HeartSaVioR I made some change so that it works without any changes to RedisEncoder and compatible with 1.x-branch as well. Please take a look. I also applied the same changes to https://github.com/apache/storm/pull/1693
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #1872: [STORM-2283] Fix multi threading issues in Default...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/1872
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #1872: [STORM-2283] Fix multi threading issues in DefaultStateSe...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/1872
@arunmahadevan
Just realized you're using Optional from JDK 8.
Given that it's a bug across 1.x version lines, could you craft a patch for 1.x? Thanks in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---