You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/06 15:31:38 UTC
[GitHub] [superset] pkdotson opened a new pull request #15551: refactor: icon to icons for tabs
pkdotson opened a new pull request #15551:
URL: https://github.com/apache/superset/pull/15551
### SUMMARY
This pr migrates old icon to icons for tab cancelx icon.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
before
<img width="192" alt="Untitled Query 2 0" src="https://user-images.githubusercontent.com/17326228/124627504-76ef6c00-de34-11eb-89ff-39c252b3b586.png">
after
<img width="197" alt="04 Untitled Query 2" src="https://user-images.githubusercontent.com/17326228/124627520-7a82f300-de34-11eb-9e17-0627a0a682eb.png">
### TESTING INSTRUCTIONS
Go to sql editor and check the tabbed cancel x icon
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15551: refactor: icon to icons for tabs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15551:
URL: https://github.com/apache/superset/pull/15551#issuecomment-875069529
@rusackas Ephemeral environment spinning up at http://54.185.27.244:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #15551: refactor: icon to icons for tabs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15551:
URL: https://github.com/apache/superset/pull/15551#issuecomment-875786068
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #15551: refactor: icon to icons for tabs
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #15551:
URL: https://github.com/apache/superset/pull/15551#issuecomment-875068529
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #15551: refactor: icon to icons for tabs
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #15551:
URL: https://github.com/apache/superset/pull/15551#discussion_r665502769
##########
File path: superset-frontend/src/components/Tabs/Tabs.tsx
##########
@@ -119,6 +119,9 @@ const StyledEditableTabs = styled(StyledTabs)`
`}
`;
+const StyledCancelXIcon = styled(Icons.CancelX)`
+ color: ${({ theme }) => theme.colors.grayscale.base};
Review comment:
Same comment as in another PR. Here we should define whether the standard is to use the `iconColor` prop or go with this approach. Additionally, we might want to use this color as the base for the Icons component in general, to avoid repetition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson merged pull request #15551: refactor: icon to icons for tabs
Posted by GitBox <gi...@apache.org>.
pkdotson merged pull request #15551:
URL: https://github.com/apache/superset/pull/15551
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #15551: refactor: icon to icons for tabs
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15551:
URL: https://github.com/apache/superset/pull/15551#issuecomment-874880100
# [Codecov](https://codecov.io/gh/apache/superset/pull/15551?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15551](https://codecov.io/gh/apache/superset/pull/15551?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7edb07e) into [master](https://codecov.io/gh/apache/superset/commit/0af5a3d600634912a0950b76ca0ba49c44ff33ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0af5a3d) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 7edb07e differs from pull request most recent head 02543f2. Consider uploading reports for the commit 02543f2 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/15551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15551 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 976 976
Lines 51320 51322 +2
Branches 6912 6912
=======================================
+ Hits 39485 39487 +2
Misses 11616 11616
Partials 219 219
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `71.39% <100.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/15551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/components/Tabs/Tabs.tsx](https://codecov.io/gh/apache/superset/pull/15551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFicy9UYWJzLnRzeA==) | `96.77% <100.00%> (+0.22%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/15551?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/15551?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0af5a3d...02543f2](https://codecov.io/gh/apache/superset/pull/15551?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org