You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/08/01 20:04:45 UTC

[GitHub] [nifi] tpalfy commented on a diff in pull request #6192: NIFI-10212 added ListSmb processor and SmbConnectionPoolService

tpalfy commented on code in PR #6192:
URL: https://github.com/apache/nifi/pull/6192#discussion_r934871047


##########
nifi-nar-bundles/nifi-smb-bundle/nifi-smb-nar/pom.xml:
##########
@@ -35,5 +35,16 @@
             <artifactId>nifi-smb-processors</artifactId>
             <version>1.17.0-SNAPSHOT</version>
         </dependency>
+        <!--dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-smb-smbj-client</artifactId>
+            <version>1.17.0-SNAPSHOT</version>
+        </dependency-->

Review Comment:
   I think we don't want to merge it this way. Can we remove it instead of just commenting out?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org