[GitHub] [nifi] jtstorck edited a comment on issue #3520: NIFI-5373 Created new module nifi-metrics

[GitBox <gi...@apache.org>]

jtstorck edited a comment on issue #3520: NIFI-5373 Created new module nifi-metrics
URL: https://github.com/apache/nifi/pull/3520#issuecomment-503299922
 
 
   As I understand it, all binary artifacts (NARs) from the NiFi build that include `Dropwizard Metrics` need to include `Dropwizard Metrics`' NOTICE in its NOTICE.  Since `nifi-metrics` has a dependency on `Dropwizard Metrics` and has some modified code from it, anything that uses `nifi-metrics` will also need to pull in `Dropwizard Metrics`' NOTICE along with the additional "derived" portion.
   
   I think the main reason we don't put NOTICEs in the JARs is because they aren't released individually and dependencies aren't included with the JAR.  When the `Extension Registry` is released, if we plan to make JARs like `nifi-metrics` available via the registry, then we can add the NOTICE to `nifi-metrics`.  I still think we'd need to specify the NOTICEs as they are in this PR, though.
   
   Additionally, since `nifi-metrics` is packaged as a JAR but contains modified code from `Dropwizard Metrics`, it probably should have a NOTICE to at least state it contains derived work?
   
   @joewitt, does this match up with the licensing guidelines?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services