You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "EvanMi (via GitHub)" <gi...@apache.org> on 2023/07/26 11:00:34 UTC
[GitHub] [camel] EvanMi opened a new pull request, #10832: fix multi-value property lost problem
EvanMi opened a new pull request, #10832:
URL: https://github.com/apache/camel/pull/10832
# Description
the multi-value property is lost
# Target
we should put the key from a multi-value (prefix) in the properties too, or the property may be lost
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] EvanMi commented on pull request #10832: fix multi-value property lost problem
Posted by "EvanMi (via GitHub)" <gi...@apache.org>.
EvanMi commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1653126968
> we should put the key from a multi-value (prefix) in the properties too, or the property may be lost
i've add the unit test and JIRA https://issues.apache.org/jira/browse/CAMEL-19663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10832: fix multi-value property lost problem
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1651585016
Can you point to an example or use-case where you had a problem? And if we agree its a bug then we need a JIRA to track this and for backports too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] EvanMi commented on pull request #10832: fix multi-value property lost problem
Posted by "EvanMi (via GitHub)" <gi...@apache.org>.
EvanMi commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1651782227
> Thanks for that, can you create a JIRA and if possible add an unit test
ok,i'll do both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #10832: fix multi-value property lost problem
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1651555897
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:camel: Maintainers, please note that first-time contributors *require manual approval* for the GitHub Actions to run.
:warning: Please note that the changes on this PR may be **tested automatically** if they change components.
:robot: Use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] EvanMi commented on pull request #10832: fix multi-value property lost problem
Posted by "EvanMi (via GitHub)" <gi...@apache.org>.
EvanMi commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1653312802
> Thanks I had to merge this manually to resolve some regens
ok, but i found you missed the toD.json. or it's really should be "turn of" but not "turn off"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10832: fix multi-value property lost problem
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1653214125
Thanks I had to merge this manually to resolve some regens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10832: fix multi-value property lost problem
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1651722923
Thanks for that, can you create a JIRA and if possible add an unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10832: fix multi-value property lost problem
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1653446609
> > Thanks I had to merge this manually to resolve some regens
>
> ok, but i found you missed the toD.json. or it's really should be "turn of" but not "turn off"
You need to fix this in the java source code - the json file is auto generated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] EvanMi commented on pull request #10832: fix multi-value property lost problem
Posted by "EvanMi (via GitHub)" <gi...@apache.org>.
EvanMi commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1651699577
> Can you point to an example or use-case where you had a problem? And if we agree its a bug then we need a JIRA to track this and for backports too.
yeah,
blabla...
toD uri="https://camel.apache.org?okStatusCodeRange=200-500&httpClient.socketTimeout=60000&bar=bar”
blabla...
on the above route, the "bar" param will be add to header, "okStatusCodeRange" will be suitable set, but "httpClient.socketTimeout" will lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #10832: fix multi-value property lost problem
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1651843045
Thank you very much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus closed pull request #10832: fix multi-value property lost problem
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus closed pull request #10832: fix multi-value property lost problem
URL: https://github.com/apache/camel/pull/10832
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] EvanMi commented on pull request #10832: fix multi-value property lost problem
Posted by "EvanMi (via GitHub)" <gi...@apache.org>.
EvanMi commented on PR #10832:
URL: https://github.com/apache/camel/pull/10832#issuecomment-1651697776
> Can you point to an example or use-case where you had a problem? And if we agree its a bug then we need a JIRA to track this and for backports too.
yeah,
blabla...
<toD uri="https://camel.apache.org?okStatusCodeRange=200-500&httpClient.socketTimeout=60000&bar=bar"></toD>
blabla...
on the above route, the "bar" param will be add to header, "okStatusCodeRange" will be suitable set, but "httpClient.socketTimeout" will lost.
> Can you point to an example or use-case where you had a problem? And if we agree its a bug then we need a JIRA to track this and for backports too.
yeah,
blabla...
<toD uri="https://camel.apache.org?okStatusCodeRange=200-500&httpClient.socketTimeout=60000&bar=bar"></toD>
blabla...
on the above route, the "bar" param will be add to header, "okStatusCodeRange" will be suitable set, but "httpClient.socketTimeout" will lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org