You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "det101 (via GitHub)" <gi...@apache.org> on 2026/07/13 06:49:44 UTC
[PR] [Feature][Connector-V2] Support JDBC sink table_options for Dameng [seatunnel]
det101 opened a new pull request, #11419:
URL: https://github.com/apache/seatunnel/pull/11419
## Purpose
Extend JDBC sink `table_options` (SaveMode auto-create) to Dameng, as a follow-up to #11047 / #11101 / #11388.
## Changes
- Add Dameng curated key whitelist: `tablespace`, `fillfactor`
- Wire `DmdbDialect.validateTableOptions` and apply options in `DamengCreateTableSqlBuilder` as Dameng `STORAGE (FILLFACTOR ..., ON "...")`
- Docs (en/zh): support matrix + dialect notes + Dameng example
- Unit tests: dialect / DDL / OptionRule coverage
## Non-goals
- Arbitrary nested `STORAGE` parameters (`INITIAL` / `NEXT` / …)
- Oracle-style `PCTFREE` / `TABLESPACE` clauses (Dameng uses `STORAGE`)
- `ALTER TABLE` on existing tables (`table_options` only applies when SaveMode creates the table)
- E2E (unit tests only for this slice)
## Test plan
- [x] `DmdbDialectTest` (supported / unsupported keys)
- [x] `DamengCreateTableSqlBuilderTest#testBuildCreateTableSqlWithTableOptions`
- [x] `JdbcTableOptionsConditionExtensionTest` (Dameng pass / unknown-key reject)
- [ ] CI on this PR
## Related
- Issue: #11047
- MySQL: #11101
- TiDB / OceanBase MySQL: #11388
- Oracle: #11416
- PostgreSQL: #11417
- Paimon: #11418
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connector-V2] Support JDBC sink table_options for Dameng [seatunnel]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11419:
URL: https://github.com/apache/seatunnel/pull/11419
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connector-V2] Support JDBC sink table_options for Dameng [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11419:
URL: https://github.com/apache/seatunnel/pull/11419#issuecomment-4968434098
Rechecked the same unchanged head `c1be135337e8` after the CI / merge-gate fact changed.
## Runtime path rechecked
```text
JDBC sink config
-> JdbcSinkFactory.optionRule()
-> JdbcTableOptionsConditionExtension
-> JdbcTableOptionsValidator.validate(...)
-> DmdbDialect.validateTableOptions(...)
-> save-mode auto create
-> DamengCreateTableSqlBuilder.build(...)
-> append STORAGE (FILLFACTOR ..., ON ...)
```
## Merge conclusion
### Conclusion: still needs fixes before merge
1. Blocking items
- The source-side blockers from my previous Daniel review still stand on this unchanged head.
2. Current gate update
- The CI / merge-gate fact I referenced earlier has changed. The current status is `CI is green on the current head`: https://github.com/apache/seatunnel/actions/runs/29304782920/job/86995812982
So my technical conclusion is unchanged on merge readiness: this PR still needs the earlier code-side fixes first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature][Connector-V2] Support JDBC sink table_options for Dameng [seatunnel]
Posted by "DanielLeens (via GitHub)" <gi...@apache.org>.
DanielLeens commented on PR #11419:
URL: https://github.com/apache/seatunnel/pull/11419#issuecomment-4975886831
Rechecked the latest head again from the Dameng `table_options` validation/build path.
The earlier Daniel source-side blockers are closed for me on this revision:
- blank values are now rejected instead of being silently dropped;
- `fillfactor` is now validated before SQL generation;
- `tablespace` is no longer run through the column `fieldIde` rewriting path.
So my current Daniel-side conclusion on this head is no longer "code blocker still open". The remaining gate is the current GitHub `Build` state.
The visible cancellation on the current fork workflow still looks more like general CI/workflow churn than a Dameng-specific failure signal. So the lowest-cost next step here is to rerun `Build` on the current head first. If the refreshed run still fails, please paste the new run link and I can help narrow it down against this updated revision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org