You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Sean Owen (JIRA)" <ji...@apache.org> on 2014/11/04 10:39:34 UTC
[jira] [Commented] (SPARK-3954) source code optimization
[ https://issues.apache.org/jira/browse/SPARK-3954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14195956#comment-14195956 ]
Sean Owen commented on SPARK-3954:
----------------------------------
"source code optimization" is not a good JIRA title. Please don't change it back again.
> source code optimization
> ------------------------
>
> Key: SPARK-3954
> URL: https://issues.apache.org/jira/browse/SPARK-3954
> Project: Spark
> Issue Type: Improvement
> Components: Streaming
> Affects Versions: 1.0.0, 1.1.0
> Reporter: 宿荣全
>
> about convert files to RDDS there are 3 loops with files sequence in spark source.
> loops files sequence:
> 1.files.map(...)
> 2.files.zip(fileRDDs)
> 3.files-size.foreach
> modiy 3 recursions to 1 recursion.
> spark source code:
> private def filesToRDD(files: Seq[String]): RDD[(K, V)] = {
> val fileRDDs = files.map(file => context.sparkContext.newAPIHadoopFile[K, V, F](file))
> files.zip(fileRDDs).foreach { case (file, rdd) => {
> if (rdd.partitions.size == 0) {
> logError("File " + file + " has no data in it. Spark Streaming can only ingest " +
> "files that have been \"moved\" to the directory assigned to the file stream. " +
> "Refer to the streaming programming guide for more details.")
> }
> }}
> new UnionRDD(context.sparkContext, fileRDDs)
> }
> // -----------------------------------------------------------------------------------
> modified code:
> private def filesToRDD(files: Seq[String]): RDD[(K, V)] = {
> val fileRDDs = for (file <- files; rdd = context.sparkContext.newAPIHadoopFile[K, V, F](file))
> yield {
> if (rdd.partitions.size == 0) {
> logError("File " + file + " has no data in it. Spark Streaming can only ingest " +
> "files that have been \"moved\" to the directory assigned to the file stream. " +
> "Refer to the streaming programming guide for more details.")
> }
> rdd
> }
> new UnionRDD(context.sparkContext, fileRDDs)
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org