You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/13 01:10:17 UTC
[GitHub] codecov-io edited a comment on issue #6862: [sqla] Fixing order-by
for non-inner-joins
codecov-io edited a comment on issue #6862: [sqla] Fixing order-by for non-inner-joins
URL: https://github.com/apache/incubator-superset/pull/6862#issuecomment-463011529
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6862?src=pr&el=h1) Report
> Merging [#6862](https://codecov.io/gh/apache/incubator-superset/pull/6862?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/3f47c61dffc60503031e0dd8fd24415d6f1f1d6a?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `25%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/6862?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6862 +/- ##
==========================================
+ Coverage 56.22% 56.31% +0.08%
==========================================
Files 527 527
Lines 23529 23533 +4
Branches 2782 2782
==========================================
+ Hits 13229 13252 +23
+ Misses 9888 9869 -19
Partials 412 412
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6862?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/6862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `81.09% <25%> (-0.42%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.01% <0%> (+0.28%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/6862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `83.56% <0%> (+0.62%)` | :arrow_up: |
| [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/6862/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.82% <0%> (+1.84%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6862?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6862?src=pr&el=footer). Last update [3f47c61...8a45d56](https://codecov.io/gh/apache/incubator-superset/pull/6862?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org