You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by joseph-onsip <gi...@git.apache.org> on 2014/08/08 04:01:52 UTC
[GitHub] cordova-lib pull request: Allow plugin modules to be .json files
GitHub user joseph-onsip opened a pull request:
https://github.com/apache/cordova-lib/pull/71
Allow plugin modules to be .json files
This lets projects include JSON files as they would in Node.js
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/joseph-onsip/cordova-lib exportJSON
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/71.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #71
----
commit 28b372e1952131e18dcfa679694bd523a3e46e20
Author: Joseph Frazier <jo...@onsip.com>
Date: 2014-08-07T14:06:39Z
Allow plugin modules to be .json files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: Allow plugin modules to be .json files
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-lib/pull/71#issuecomment-51634361
This seems like it could be a cool feature; do you have a use case for it?
We should probably open a [JIRA](https://issues.apache.org/jira/browse/CB) issue for a feature request as well, so that we can discuss it there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-7278 Allow plugin modules to be .json...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/71
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-7278 Allow plugin modules to be .json...
Posted by joseph-onsip <gi...@git.apache.org>.
Github user joseph-onsip commented on the pull request:
https://github.com/apache/cordova-lib/pull/71#issuecomment-51646216
Sure, I work on a [project](https://github.com/onsip/SIP.js) that [requires its package.json](https://github.com/onsip/SIP.js/blob/817c7038c0be0d66a68d4c1f5d5e99678017186b/src/SIP.js#L10-L19). In order to make the project usable as a Cordova plugin, I had to copy the relevant portions of package.json into a separate file, [cordova_package.json.js](https://github.com/onsip/SIP.js/commit/0862df7c825b27f90a5665f584334b232eddf644#diff-0), then [specify *that* file as the src of the "package.json" module](https://github.com/onsip/SIP.js/commit/0862df7c825b27f90a5665f584334b232eddf644#diff-53f390d375398624afe1cfe1125f42bfR7).
If plugin modules could be .json files, I could just specify package.json as the src of the module, instead of needing to manually synchronize cordova_package.json.js with package.json.
I opened [CB-7278](https://issues.apache.org/jira/browse/CB-7278) on JIRA, as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-7278 Allow plugin modules to be .json...
Posted by joseph-onsip <gi...@git.apache.org>.
Github user joseph-onsip commented on the pull request:
https://github.com/apache/cordova-lib/pull/71#issuecomment-52725036
Cheers Jesse! I'll be sure to submit a CLA if I contribute larger changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-lib pull request: CB-7278 Allow plugin modules to be .json...
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/71#issuecomment-52256866
Merged, Thanks Joseph!
We will need a CLA on file for any more substantial pull requests.
http://cordova.apache.org/#contribute
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---