You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/05 01:21:21 UTC

[GitHub] [spark] kevinjmh commented on issue #19082: [SPARK-21870][SQL] Split aggregation code into small functions

kevinjmh commented on issue #19082: [SPARK-21870][SQL] Split aggregation code into small functions
URL: https://github.com/apache/spark/pull/19082#issuecomment-469495590
 
 
   > Since #19813 fixes this issue, so I'll close this. Thanks!
   
   I track to here from jira ticket SPARK-23791, which contains a test case.
   #19813 is merged and then reverted. From the discussion under #19813, #21193 is raised.
   But when I run the testcase on spark 2.4, I don't think the issue is fix.
   
   Test result of 3 rounds : `(coden on, codegen off)`
   (80.807065794,13.359716698), 
   (73.170440475,10.728186286), 
   (72.61997856,10.436293345))

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org