[GitHub] [spark] ulysses-you commented on pull request #33899: [SPARK-36652][SQL] AQE dynamic join selection should not apply to non-equi join

[GitBox <gi...@apache.org>]

ulysses-you commented on pull request #33899:
URL: https://github.com/apache/spark/pull/33899#issuecomment-911801167


   @c21 thank you for the fix, I think this issue only exists in master branch since the hint check https://github.com/apache/spark/pull/32355 is only merged into master after branch-3.2 cut.
   
   The origin idea of `DynamicJoinSelection` is giving some hint which can be applied potentially after match the join strategy so it's no harm for non-eqai join. The only thing changed is we add the hint check. So I think it's safe to only match the equi join at `DynamicJoinSelection` side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org