You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2017/04/05 05:16:10 UTC
[1/2] incubator-impala git commit: IMPALA-4293: query profile should
include error log
Repository: incubator-impala
Updated Branches:
refs/heads/master be8d15122 -> 676a88f34
IMPALA-4293: query profile should include error log
This puts the string-ified error log into an "Errors:"
field in the profile.
Testing:
Visually checked that the field showed up in the profiles in
the web UI. Ran core tests.
Change-Id: Ib9b7298df6a6f05a8cdb486283ae4728b00a5ef1
Reviewed-on: http://gerrit.cloudera.org:8080/6553
Reviewed-by: Henry Robinson <he...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/cfcb5f40
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/cfcb5f40
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/cfcb5f40
Branch: refs/heads/master
Commit: cfcb5f40017bc596bb26d4736ca73a318f5e0e6d
Parents: be8d151
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Tue Apr 4 10:43:22 2017 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Wed Apr 5 03:03:57 2017 +0000
----------------------------------------------------------------------
be/src/service/impala-server.cc | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/cfcb5f40/be/src/service/impala-server.cc
----------------------------------------------------------------------
diff --git a/be/src/service/impala-server.cc b/be/src/service/impala-server.cc
index 313708e..80c1507 100644
--- a/be/src/service/impala-server.cc
+++ b/be/src/service/impala-server.cc
@@ -966,6 +966,8 @@ Status ImpalaServer::UnregisterQuery(const TUniqueId& query_id, bool check_infli
exec_summary = PrintExecSummary(summary);
}
exec_state->summary_profile()->AddInfoString("ExecSummary", exec_summary);
+ exec_state->summary_profile()->AddInfoString("Errors",
+ exec_state->coord()->GetErrorLog());
const unordered_set<TNetworkAddress>& unique_hosts =
exec_state->schedule()->unique_hosts();
[2/2] incubator-impala git commit: IMPALA-5156: Drop VLOG level
passed into Kudu client
Posted by ta...@apache.org.
IMPALA-5156: Drop VLOG level passed into Kudu client
The Kudu logging is very verbose and all of the logging may
affect performance. This change reduces the Kudu client log
level to v-1, since Impala is typically run at v=1 and isn't
too noisy.
In some simple concurrency testing, Todd found that reducing
the vlog level resulted in an increase in throughput from
~17 qps to 60qps.
Change-Id: I6f160e20de37ac13887ccfebc5fb1d595fd05db1
Reviewed-on: http://gerrit.cloudera.org:8080/6549
Reviewed-by: Matthew Jacobs <mj...@cloudera.com>
Tested-by: Impala Public Jenkins
Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/676a88f3
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/676a88f3
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/676a88f3
Branch: refs/heads/master
Commit: 676a88f346c3dac57ffe0b5742a64ee7136b6bb1
Parents: cfcb5f4
Author: Matthew Jacobs <mj...@cloudera.com>
Authored: Tue Apr 4 13:36:01 2017 -0700
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Wed Apr 5 04:52:59 2017 +0000
----------------------------------------------------------------------
be/src/exec/kudu-util.cc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/676a88f3/be/src/exec/kudu-util.cc
----------------------------------------------------------------------
diff --git a/be/src/exec/kudu-util.cc b/be/src/exec/kudu-util.cc
index ef1c74b..e7afb7c 100644
--- a/be/src/exec/kudu-util.cc
+++ b/be/src/exec/kudu-util.cc
@@ -17,6 +17,7 @@
#include "exec/kudu-util.h"
+#include <algorithm>
#include <string>
#include <sstream>
@@ -102,7 +103,8 @@ void InitKuduLogging() {
DCHECK(KuduIsAvailable());
static kudu::client::KuduLoggingFunctionCallback<void*> log_cb(&LogKuduMessage, NULL);
kudu::client::InstallLoggingCallback(&log_cb);
- kudu::client::SetVerboseLogLevel(FLAGS_v);
+ // Kudu client logging is more noisy than Impala logging, log at v-1.
+ kudu::client::SetVerboseLogLevel(std::max(0, FLAGS_v - 1));
}
} // namespace impala