You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/29 17:38:46 UTC

[GitHub] [spark] mundaym commented on pull request #29259: [SPARK-29918][SQL][FOLLOWUP][TEST] Fix endianness issues in tests in RecordBinaryComparatorSuite

mundaym commented on pull request #29259:
URL: https://github.com/apache/spark/pull/29259#issuecomment-665598880


   Does anyone know if there is a clean(er) way to copy an 8 byte array into a single element in an UnsafeRow? I'm trying to avoid the byte reversal but as far as I can tell the interface requires me to go through `setLong` to set an 8 byte value which means I need to take into account the endianness of the platform to get a particular byte layout in memory (i.e. use reverseBytes or go through a ByteBuffer). The other option is to modify the byte array that backs the UnsafeRow directly but I don't think that would necessarily be robust against any future UnsafeRow changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org