You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tzulitai <gi...@git.apache.org> on 2017/06/02 13:20:38 UTC
[GitHub] flink pull request #4052: [FLINK-6808] Implement snapshotConfiguration/ensur...
GitHub user tzulitai opened a pull request:
https://github.com/apache/flink/pull/4052
[FLINK-6808] Implement snapshotConfiguration/ensureCompatibility for CoGroupedStreams.UnionSerializer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tzulitai/flink FLINK-6808
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4052.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4052
----
commit bbf3dd13157610f35a6f938008cde726be201474
Author: Tzu-Li (Gordon) Tai <tz...@apache.org>
Date: 2017-06-02T13:15:32Z
[FLINK-6808] Implement snapshotConfiguration/ensureCompatibility for CoGroupedStreams.UnionSerializer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4052: [FLINK-6808] Implement compatibility methods for C...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4052#discussion_r119867943
--- Diff: flink-tests/src/test/java/org/apache/flink/test/streaming/runtime/CoGroupJoinITCase.java ---
@@ -324,6 +329,41 @@ public void invoke(String value) throws Exception {
Assert.assertEquals(expectedResult, testResults);
}
+ @Test
+ public void testCoGroupOperatorWithCheckpoint() throws Exception {
--- End diff --
Maybe mention that this is meant to check the snapshotting and the problem that was previously undetected.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4052: [FLINK-6808] Implement compatibility methods for CoGroupe...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4052
Thanks for the review 😄
There was a checkstyle violation; will merge after another Travis run.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4052: [FLINK-6808] Implement compatibility methods for C...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4052#discussion_r119867402
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/CoGroupedStreams.java ---
@@ -77,7 +82,7 @@
private final DataStream<T2> input2;
/**
- * Creates new CoGroped data streams, which are the first step towards building a streaming
--- End diff --
Groped ... 😅
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4052: [FLINK-6808] Implement compatibility methods for C...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4052
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---