You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/11/08 16:47:45 UTC

[GitHub] [airflow] bbovenzi commented on a diff in pull request #26457: Add user comment to task instance and dag run

bbovenzi commented on code in PR #26457:
URL: https://github.com/apache/airflow/pull/26457#discussion_r1016881422


##########
airflow/www/static/js/api/useDatasetEvents.ts:
##########
@@ -30,7 +30,7 @@ export default function useDatasetEvents({
   const query = useQuery(
     ['datasets-events', datasetId, sourceDagId, sourceRunId, sourceTaskId, sourceMapIndex, limit, offset, orderBy],
     () => {
-      const datasetsUrl = getMetaValue('dataset_events_api') || '/api/v1/datasets/events';
+      const datasetsUrl = getMetaValue('dataset_events_api');

Review Comment:
   Yeah, `getMetaValue()` was updated to handle `undefined` better. This is fine.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org