[GitHub] [incubator-superset] khtruong commented on a change in pull request #8826: Add user agent logs

[GitBox <gi...@apache.org>]

khtruong commented on a change in pull request #8826: Add user agent logs
URL: https://github.com/apache/incubator-superset/pull/8826#discussion_r357775247
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -2650,7 +2650,12 @@ def validate_sql_json(self):
                 return json_error_response(f"{msg}")
 
     def _sql_json_async(
-        self, session: Session, rendered_query: str, query: Query, expand_data: bool
+        self,
+        session: Session,
+        rendered_query: str,
+        query: Query,
+        expand_data: bool,
+        log_params: dict,
 
 Review comment:
   I'll put Dict[str, Any] to allow flexibility for future logs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org