You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by bastiliu <gi...@git.apache.org> on 2015/11/25 13:29:24 UTC
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
GitHub user bastiliu opened a pull request:
https://github.com/apache/storm/pull/904
STORM-1353 Update "jstorm-import" branch to the latest JStorm release 2.1.0
Update the reference banch "jstorm-import" with latest JStorm release 2.1.0, since many JStorm features listed in JStorm merging plan are not included.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bastiliu/storm jstorm-import
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/904.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #904
----
commit 7eaf06513183228d8c0a8ac032733f0ec47ba9a7
Author: basti.lj <ba...@alibaba-inc.com>
Date: 2015-11-25T12:04:48Z
Update JStorm to latest release 2.1.0
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-161362165
maybe need a modify list to display JStorm's update
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/904
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-161111124
Thanks @bastiliu I merged this into the jstorm-import.
**One important thing to note:**
This pull request introduced highchart.js which has a commercial license and can't be included in an Apache release. If we end up using the jstorm-ui code, highcharts.js will have to be removed and replaced with something that's compatible with ASF license policy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-161361062
@wuchong Good to hear. Visually they look nearly identical, and the license looks compatible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by bastiliu <gi...@git.apache.org>.
Github user bastiliu commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-161157842
@ptgoetz Thanks for the information. We will find a new solution which is compatible with ASF license policy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-161286041
Hi @ptgoetz , thanks for the note. We have tried a lot of alternative solutions, such as: d3, chart.js, xCharts, chartist.js and ECharts. Finally we find that [ECharts](http://echarts.baidu.com/index-en.html) is best meet our needs and [its license](https://github.com/ecomfe/echarts/blob/master/LICENSE.txt) is much like BSD which is compatible with ASF license I think.
The image below is that we use ECharts to re-implement metric charts.
and this is the version using highcharts
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by zhuoliu <gi...@git.apache.org>.
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-159692305
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by hustfxj <gi...@git.apache.org>.
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-159601049
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-159601051
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by darionyaphet <gi...@git.apache.org>.
Github user darionyaphet commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-159637347
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by bastiliu <gi...@git.apache.org>.
Github user bastiliu commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-161157816
@ptgoetz Thanks for the information. We find a new solution which is compatible with ASF license policy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1353 Update "jstorm-import" branch to th...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/904#issuecomment-159662148
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---