You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by GitBox <gi...@apache.org> on 2019/12/18 01:54:07 UTC
[GitHub] [submarine] tangzhankun commented on issue #130: SUBMARINE-321. Add
JobManager and SubmitterManager components
tangzhankun commented on issue #130: SUBMARINE-321. Add JobManager and SubmitterManager components
URL: https://github.com/apache/submarine/pull/130#issuecomment-566830915
Thanks a lot! Wanqiang!
The patch looks good to me. Do we need to add simple test cases? Or we can add in following patch.
Another question is do we need to add default values explicitly in submarine-site.xml? Maybe we can add that later too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org