You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/07/19 18:28:09 UTC
[GitHub] [superset] pkdotson opened a new pull request, #20773: chore: update text for dbconn modal
pkdotson opened a new pull request, #20773:
URL: https://github.com/apache/superset/pull/20773
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This pr updates the dbconnection modal text after user successfully connects to database.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONSON
Go to db connection modal and connect database. User should see updated text.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1202935155
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on a diff in pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
pkdotson commented on code in PR #20773:
URL: https://github.com/apache/superset/pull/20773#discussion_r938981978
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/ModalHeader.tsx:
##########
@@ -108,19 +108,11 @@ const ModalHeader = ({
<StyledStickyHeader>
<StyledFormHeader>
<p className="helper-top"> STEP 3 OF 3 </p>
- <h4 className="step-3-text">
- Your database was successfully connected! Create a dataset to begin
- visualizing your data as a chart or go to SQL Lab to query your data.
- </h4>
- <p className="helper-bottom">
- Need help? Learn more about{' '}
- <a
- href={documentationLink(db?.engine)}
- target="_blank"
- rel="noopener noreferrer"
- >
- connecting to {dbModel.name}.
- </a>
+ <h4 className="step-3-text">Database connected</h4>
+ <p className="subheader-text">
+ {' '}
Review Comment:
Nope I'll remove that. Lint seems to be happy with these removed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #20773:
URL: https://github.com/apache/superset/pull/20773#discussion_r938337999
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/ModalHeader.tsx:
##########
@@ -108,19 +108,11 @@ const ModalHeader = ({
<StyledStickyHeader>
<StyledFormHeader>
<p className="helper-top"> STEP 3 OF 3 </p>
- <h4 className="step-3-text">
- Your database was successfully connected! Create a dataset to begin
- visualizing your data as a chart or go to SQL Lab to query your data.
- </h4>
- <p className="helper-bottom">
- Need help? Learn more about{' '}
- <a
- href={documentationLink(db?.engine)}
- target="_blank"
- rel="noopener noreferrer"
- >
- connecting to {dbModel.name}.
- </a>
+ <h4 className="step-3-text">Database connected</h4>
+ <p className="subheader-text">
+ {' '}
Review Comment:
what is the empty space here used for? Do we still need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1206955856
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1205710679
@pkdotson Ephemeral environment spinning up at http://54.218.88.203:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
pkdotson commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1205706780
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1202967458
A few more small design nits:
Can you change the line height on the subtext (Create a dataset to start visualizing...) to 17px per the mocks?
Maybe just check with design about the color of the buttons, too? It looks darker to me in the mocks.
Also, when I click the back button on that screen, I still see the buttons:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #20773:
URL: https://github.com/apache/superset/pull/20773#discussion_r935795809
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/ModalHeader.tsx:
##########
@@ -108,19 +108,11 @@ const ModalHeader = ({
<StyledStickyHeader>
<StyledFormHeader>
<p className="helper-top"> STEP 3 OF 3 </p>
- <h4 className="step-3-text">
- Your database was successfully connected! Create a dataset to begin
- visualizing your data as a chart or go to SQL Lab to query your data.
- </h4>
- <p className="helper-bottom">
- Need help? Learn more about{' '}
- <a
- href={documentationLink(db?.engine)}
- target="_blank"
- rel="noopener noreferrer"
- >
- connecting to {dbModel.name}.
- </a>
+ <h4 className="step-3-text">Database connected</h4>
+ <p>
+ {' '}
+ Create a dataset to start visualizing your data as a chart or got to
Review Comment:
I can't find it in this file, but it looks like the button at the bottom in the mocks is "Create Dataset" instead of "Create a Dataset"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1202939733
@eschutho Ephemeral environment spinning up at http://54.191.17.248:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #20773:
URL: https://github.com/apache/superset/pull/20773#discussion_r935781876
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/ModalHeader.tsx:
##########
@@ -108,19 +108,11 @@ const ModalHeader = ({
<StyledStickyHeader>
<StyledFormHeader>
<p className="helper-top"> STEP 3 OF 3 </p>
- <h4 className="step-3-text">
- Your database was successfully connected! Create a dataset to begin
- visualizing your data as a chart or go to SQL Lab to query your data.
- </h4>
- <p className="helper-bottom">
- Need help? Learn more about{' '}
- <a
- href={documentationLink(db?.engine)}
- target="_blank"
- rel="noopener noreferrer"
- >
- connecting to {dbModel.name}.
- </a>
+ <h4 className="step-3-text">Database connected</h4>
+ <p>
+ {' '}
+ Create a dataset to start visualizing your data as a chart or got to
Review Comment:
typo :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1189460791
# [Codecov](https://codecov.io/gh/apache/superset/pull/20773?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20773](https://codecov.io/gh/apache/superset/pull/20773?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e7af61b) into [master](https://codecov.io/gh/apache/superset/commit/e2d3ea831a7c634aeb2364a469a142c3514e4cf3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e2d3ea8) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #20773 +/- ##
=======================================
Coverage 66.35% 66.35%
=======================================
Files 1756 1756
Lines 66725 66725
Branches 7049 7049
=======================================
Hits 44275 44275
Misses 20653 20653
Partials 1797 1797
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.93% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...s/CRUD/data/database/DatabaseModal/ModalHeader.tsx](https://codecov.io/gh/apache/superset/pull/20773/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL01vZGFsSGVhZGVyLnRzeA==) | `66.66% <ø> (ø)` | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1203006486
cc @jess-dillard if you have any feedback to add
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1203066934
* The button text on the Create Dataset and Query Data in SQL Lab doesn't look centered - there's too much space on the right side of the text - can you please double check if you're using the secondary button component? The spacing should be correct on the component
* Mocks say "begin visualizing" rather than "start visualizing" on the subheader text
* Typo - "to to query your data" with an extra "to"
(Button color looks ok)
I noticed that the X button and the close button on the Dataset creation modal don't work when I am linked to it from the database connection screen, but they work normally when you open the modal from the CRUD view:
When clicking either of the buttons from the database connection success screen, the header/subheader disappeared and buttons jumped to the top of the modal and a loading state showed up on the modal. The modal shouldn't be moving when the screen is refreshing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
pkdotson commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1203174653
> A few more small design nits: Can you change the line height on the subtext (Create a dataset to start visualizing...) to 17px per the mocks? Maybe just check with design about the color of the buttons, too? It looks darker to me in the mocks.
>
> Also, when I click the back button on that screen, I still see the buttons: 
In the mocks the text is 14px unless i'm mistaken.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson merged pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
pkdotson merged PR #20773:
URL: https://github.com/apache/superset/pull/20773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on a diff in pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
yousoph commented on code in PR #20773:
URL: https://github.com/apache/superset/pull/20773#discussion_r935836288
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/ModalHeader.tsx:
##########
@@ -108,19 +108,11 @@ const ModalHeader = ({
<StyledStickyHeader>
<StyledFormHeader>
<p className="helper-top"> STEP 3 OF 3 </p>
- <h4 className="step-3-text">
- Your database was successfully connected! Create a dataset to begin
- visualizing your data as a chart or go to SQL Lab to query your data.
- </h4>
- <p className="helper-bottom">
- Need help? Learn more about{' '}
- <a
- href={documentationLink(db?.engine)}
- target="_blank"
- rel="noopener noreferrer"
- >
- connecting to {dbModel.name}.
- </a>
+ <h4 className="step-3-text">Database connected</h4>
+ <p>
+ {' '}
+ Create a dataset to start visualizing your data as a chart or got to
+ SQL Lab to to query your data
Review Comment:
Add a period after data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on a diff in pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
eschutho commented on code in PR #20773:
URL: https://github.com/apache/superset/pull/20773#discussion_r936897660
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/ModalHeader.tsx:
##########
@@ -108,19 +108,11 @@ const ModalHeader = ({
<StyledStickyHeader>
<StyledFormHeader>
<p className="helper-top"> STEP 3 OF 3 </p>
- <h4 className="step-3-text">
- Your database was successfully connected! Create a dataset to begin
- visualizing your data as a chart or go to SQL Lab to query your data.
- </h4>
- <p className="helper-bottom">
- Need help? Learn more about{' '}
- <a
- href={documentationLink(db?.engine)}
- target="_blank"
- rel="noopener noreferrer"
- >
- connecting to {dbModel.name}.
- </a>
+ <h4 className="step-3-text">Database connected</h4>
+ <p>
+ {' '}
+ Create a dataset to start visualizing your data as a chart or got to
Review Comment:
thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eschutho commented on pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
eschutho commented on PR #20773:
URL: https://github.com/apache/superset/pull/20773#issuecomment-1204188715
@pkdotson, yes correct the font is 14px/17px for font size and line height. I think it's the line height that needs to be adjusted just a tweak on the `Create a dataset to start visualizing...` text. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] pkdotson commented on a diff in pull request #20773: chore: update text for dbconn modal
Posted by GitBox <gi...@apache.org>.
pkdotson commented on code in PR #20773:
URL: https://github.com/apache/superset/pull/20773#discussion_r935791691
##########
superset-frontend/src/views/CRUD/data/database/DatabaseModal/ModalHeader.tsx:
##########
@@ -108,19 +108,11 @@ const ModalHeader = ({
<StyledStickyHeader>
<StyledFormHeader>
<p className="helper-top"> STEP 3 OF 3 </p>
- <h4 className="step-3-text">
- Your database was successfully connected! Create a dataset to begin
- visualizing your data as a chart or go to SQL Lab to query your data.
- </h4>
- <p className="helper-bottom">
- Need help? Learn more about{' '}
- <a
- href={documentationLink(db?.engine)}
- target="_blank"
- rel="noopener noreferrer"
- >
- connecting to {dbModel.name}.
- </a>
+ <h4 className="step-3-text">Database connected</h4>
+ <p>
+ {' '}
+ Create a dataset to start visualizing your data as a chart or got to
Review Comment:
Oops good catch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org