[GitHub] incubator-trafficcontrol pull request #751: [TC-462] Ds tenancy validation r...

[mitchell852 <gi...@git.apache.org>]

Github user mitchell852 commented on a diff in the pull request:

    https://github.com/apache/incubator-trafficcontrol/pull/751#discussion_r130975670
  
    --- Diff: traffic_ops/app/lib/API/DeliveryServiceRegexes.pm ---
    @@ -222,6 +262,18 @@ sub delete {
     		return $self->forbidden();
     	}
     
    +	my $ds = $self->db->resultset('Deliveryservice')->find( { id => $ds_id } );
    +	if ( !defined($ds) ) {
    +		#allow deletion if the ds is not valid
    --- End diff --
    
    can  you make this change? this doesn't make sense to me. if the ds doesn't exist, don't worry about deleting ds regexes...just throw a not_found()


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---