You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/04/01 19:43:57 UTC
[GitHub] [beam] lostluck opened a new pull request, #26067: [Go SDK] Work around for #26066 in mongodbio.
lostluck opened a new pull request, #26067:
URL: https://github.com/apache/beam/pull/26067
Works around #26066 which manifests in Go 1.20+. Wrapping the generic function instances explicitly avoids the name change in the reflect package for generic types. This unblocks migration beam infra to Go 1.20.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26067:
URL: https://github.com/apache/beam/pull/26067#issuecomment-1493134377
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26067:
URL: https://github.com/apache/beam/pull/26067#issuecomment-1493109241
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26067:
URL: https://github.com/apache/beam/pull/26067#issuecomment-1493096609
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @riteshghorse for label go.
R: @Abacn for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26067:
URL: https://github.com/apache/beam/pull/26067#issuecomment-1493130330
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26067:
URL: https://github.com/apache/beam/pull/26067#issuecomment-1493091130
## [Codecov](https://codecov.io/gh/apache/beam/pull/26067?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26067](https://codecov.io/gh/apache/beam/pull/26067?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a52931b) into [master](https://codecov.io/gh/apache/beam/commit/f93cb9af5312de9ef1771638be1d17586d55fa9a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f93cb9a) will **decrease** coverage by `0.01%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #26067 +/- ##
==========================================
- Coverage 71.43% 71.42% -0.01%
==========================================
Files 782 782
Lines 102848 102856 +8
==========================================
+ Hits 73467 73470 +3
- Misses 27904 27910 +6
+ Partials 1477 1476 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `54.08% <33.33%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/26067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/go/pkg/beam/io/mongodbio/coder.go](https://codecov.io/gh/apache/beam/pull/26067?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9nby9wa2cvYmVhbS9pby9tb25nb2RiaW8vY29kZXIuZ28=) | `68.18% <33.33%> (-15.16%)` | :arrow_down: |
... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26067/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26067:
URL: https://github.com/apache/beam/pull/26067#issuecomment-1493109231
cc: @johannaojeling
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26067:
URL: https://github.com/apache/beam/pull/26067#issuecomment-1493109337
(The GoPortable Precommit flake is being worked on in #26062)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26067:
URL: https://github.com/apache/beam/pull/26067#issuecomment-1493096362
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johannaojeling commented on pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "johannaojeling (via GitHub)" <gi...@apache.org>.
johannaojeling commented on PR #26067:
URL: https://github.com/apache/beam/pull/26067#issuecomment-1493318091
LGTM. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #26067:
URL: https://github.com/apache/beam/pull/26067
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26067: [Go SDK] Work around for #26066 in mongodbio.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26067:
URL: https://github.com/apache/beam/pull/26067#issuecomment-1493388171
Thanks for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org