You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/30 15:52:04 UTC

[GitHub] [spark] gengliangwang commented on a change in pull request #24745: [SPARK-27849][SQL][FollowUp] Fix the testing regex in DataSourceScanRedactionTest

gengliangwang commented on a change in pull request #24745: [SPARK-27849][SQL][FollowUp] Fix the testing regex in DataSourceScanRedactionTest
URL: https://github.com/apache/spark/pull/24745#discussion_r289052856
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/execution/DataSourceScanExecRedactionSuite.scala
 ##########
 @@ -31,7 +31,7 @@ import org.apache.spark.sql.test.SharedSQLContext
 abstract class DataSourceScanRedactionTest extends QueryTest with SharedSQLContext {
 
   override protected def sparkConf: SparkConf = super.sparkConf
-    .set("spark.redaction.string.regex", "file:/[\\w-_@/]+")
+    .set("spark.redaction.string.regex", "file:/[^\\]\\s]+")
 
 Review comment:
   Actually matching `[^\\]]+` should be enough. Matching spaces also for double insurance. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org