You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tiles.apache.org by "Xiaoming Shi (JIRA)" <ji...@apache.org> on 2011/02/24 03:18:38 UTC
[jira] Created: (TILES-521) JspFactory.getDefaultFactory() is
synchronized, We can cache the return value to improve performance
JspFactory.getDefaultFactory() is synchronized, We can cache the return value to improve performance
----------------------------------------------------------------------------------------------------
Key: TILES-521
URL: https://issues.apache.org/jira/browse/TILES-521
Project: Tiles
Issue Type: Bug
Components: tiles-el
Affects Versions: 2.2.2
Reporter: Xiaoming Shi
In the file
tiles-2.2.2/src/tiles-el/src/main/java/org/apache/tiles/el/JspExpressionFactoryFactory.java line:61
The value returned by JspFactory.getDefaultFactory() can be cached to reduce race and improve performance
(Similar to the Apache Bug, https://issues.apache.org/bugzilla/show_bug.cgi?id=44408)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TILES-521) JspFactory.getDefaultFactory() is
synchronized, We can cache the return value to improve performance
Posted by "Xiaoming Shi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998898#comment-12998898 ]
Xiaoming Shi commented on TILES-521:
------------------------------------
Hi Antonio,
Since JspExpressionFactoryFactory itself is a Factory, the best method may be caching the value of JspExpressionFactory where it is used. But it may affect many codes.
The other method is to add a field in the class JspExpressionFactoryFactory which can be used to store the return value of JspFactory.getDefaultFactory(). If a JspExpressionFactory object is only used for once, then this method may not improve any performance.
> JspFactory.getDefaultFactory() is synchronized, We can cache the return value to improve performance
> ----------------------------------------------------------------------------------------------------
>
> Key: TILES-521
> URL: https://issues.apache.org/jira/browse/TILES-521
> Project: Tiles
> Issue Type: Bug
> Components: tiles-el
> Affects Versions: 2.2.2
> Reporter: Xiaoming Shi
>
> In the file
> tiles-2.2.2/src/tiles-el/src/main/java/org/apache/tiles/el/JspExpressionFactoryFactory.java line:61
> The value returned by JspFactory.getDefaultFactory() can be cached to reduce race and improve performance
> (Similar to the Apache Bug, https://issues.apache.org/bugzilla/show_bug.cgi?id=44408)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (TILES-521) JspFactory.getDefaultFactory() is
synchronized, We can cache the return value to improve performance
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli updated TILES-521:
-----------------------------------
Remaining Estimate: 0h
Original Estimate: 0h
> JspFactory.getDefaultFactory() is synchronized, We can cache the return value to improve performance
> ----------------------------------------------------------------------------------------------------
>
> Key: TILES-521
> URL: https://issues.apache.org/jira/browse/TILES-521
> Project: Tiles
> Issue Type: Bug
> Components: tiles-el
> Affects Versions: 2.2.2
> Reporter: Xiaoming Shi
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> In the file
> tiles-2.2.2/src/tiles-el/src/main/java/org/apache/tiles/el/JspExpressionFactoryFactory.java line:61
> The value returned by JspFactory.getDefaultFactory() can be cached to reduce race and improve performance
> (Similar to the Apache Bug, https://issues.apache.org/bugzilla/show_bug.cgi?id=44408)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (TILES-521) JspFactory.getDefaultFactory() is
synchronized, We can cache the return value to improve performance
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998757#comment-12998757 ]
Antonio Petrelli commented on TILES-521:
----------------------------------------
I agree, but can you provide a patch? This way it will be fixed sooner.
> JspFactory.getDefaultFactory() is synchronized, We can cache the return value to improve performance
> ----------------------------------------------------------------------------------------------------
>
> Key: TILES-521
> URL: https://issues.apache.org/jira/browse/TILES-521
> Project: Tiles
> Issue Type: Bug
> Components: tiles-el
> Affects Versions: 2.2.2
> Reporter: Xiaoming Shi
>
> In the file
> tiles-2.2.2/src/tiles-el/src/main/java/org/apache/tiles/el/JspExpressionFactoryFactory.java line:61
> The value returned by JspFactory.getDefaultFactory() can be cached to reduce race and improve performance
> (Similar to the Apache Bug, https://issues.apache.org/bugzilla/show_bug.cgi?id=44408)
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (TILES-521) JspFactory.getDefaultFactory() is
synchronized, We can cache the return value to improve performance
Posted by "Antonio Petrelli (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TILES-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antonio Petrelli closed TILES-521.
----------------------------------
Resolution: Won't Fix
> JspFactory.getDefaultFactory() is synchronized, We can cache the return value to improve performance
> ----------------------------------------------------------------------------------------------------
>
> Key: TILES-521
> URL: https://issues.apache.org/jira/browse/TILES-521
> Project: Tiles
> Issue Type: Bug
> Components: tiles-el
> Affects Versions: 2.2.2
> Reporter: Xiaoming Shi
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> In the file
> tiles-2.2.2/src/tiles-el/src/main/java/org/apache/tiles/el/JspExpressionFactoryFactory.java line:61
> The value returned by JspFactory.getDefaultFactory() can be cached to reduce race and improve performance
> (Similar to the Apache Bug, https://issues.apache.org/bugzilla/show_bug.cgi?id=44408)
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira