You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by mi...@apache.org on 2017/01/12 16:03:30 UTC
[1/2] git commit: [flex-sdk] [refs/heads/release4.16.0] - FLEX-27509
CAUSE: In an AdvancedDataGrid with non-text item renderers
AdvancedDataGrid.expandItem() applies masks onto those item renderers when it
needs to close a node. At the same time, Advance
Repository: flex-sdk
Updated Branches:
refs/heads/release4.16.0 db8c1bf7c -> 7418641ac
FLEX-27509
CAUSE: In an AdvancedDataGrid with non-text item renderers AdvancedDataGrid.expandItem() applies masks onto those item renderers when it needs to close a node. At the same time, AdvancedListBase has its own custom mechanism for using masks to scroll vertically in a more efficient way. In order to detect whether it's used this mechanism, and reset the changes (detection happens in AdvancedListBase.removeClipMask(), while the mechanism is applied in addClipMask()), it simply asks whether the non-text item renderer has a mask applied. However, this mask could have been applied by the expandItem() mechanism mentioned above, which means that addClipMask() will never have been called. As a result, itemMaskFreeList is still null, which leads to the fatal.
SOLUTION: Ideally there should be a flag that specifies whether AdvancedListBase.addClipMask() has applied the masking mechanism. But for now we can simply check that itemMaskFreeList isn't null before we use it.
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/4102e70b
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/4102e70b
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/4102e70b
Branch: refs/heads/release4.16.0
Commit: 4102e70b6c9523b7b1f29d0b8c82602f421dc535
Parents: db8c1bf
Author: Mihai Chira <mi...@apache.org>
Authored: Thu Jan 12 13:24:40 2017 +0100
Committer: Mihai Chira <mi...@apache.org>
Committed: Thu Jan 12 16:52:37 2017 +0100
----------------------------------------------------------------------
.../src/mx/controls/listClasses/AdvancedListBase.as | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/4102e70b/frameworks/projects/advancedgrids/src/mx/controls/listClasses/AdvancedListBase.as
----------------------------------------------------------------------
diff --git a/frameworks/projects/advancedgrids/src/mx/controls/listClasses/AdvancedListBase.as b/frameworks/projects/advancedgrids/src/mx/controls/listClasses/AdvancedListBase.as
index 854f0df..a872381 100644
--- a/frameworks/projects/advancedgrids/src/mx/controls/listClasses/AdvancedListBase.as
+++ b/frameworks/projects/advancedgrids/src/mx/controls/listClasses/AdvancedListBase.as
@@ -5231,7 +5231,10 @@ public class AdvancedListBase extends ScrollControlBase
}
else if (item && item.mask)
{
- itemMaskFreeList.push(item.mask);
+ if(itemMaskFreeList)
+ {
+ itemMaskFreeList.push(item.mask);
+ }
item.mask = null;
}
}
[2/2] git commit: [flex-sdk] [refs/heads/release4.16.0] - FLEX-35149
updating release notes with fix for FLEX-27509
Posted by mi...@apache.org.
FLEX-35149 updating release notes with fix for FLEX-27509
Project: http://git-wip-us.apache.org/repos/asf/flex-sdk/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-sdk/commit/7418641a
Tree: http://git-wip-us.apache.org/repos/asf/flex-sdk/tree/7418641a
Diff: http://git-wip-us.apache.org/repos/asf/flex-sdk/diff/7418641a
Branch: refs/heads/release4.16.0
Commit: 7418641acc7a1fafaf4de965842e8b342a9a46be
Parents: 4102e70
Author: Mihai Chira <mi...@apache.org>
Authored: Thu Jan 12 17:02:42 2017 +0100
Committer: Mihai Chira <mi...@apache.org>
Committed: Thu Jan 12 17:02:42 2017 +0100
----------------------------------------------------------------------
RELEASE_NOTES | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-sdk/blob/7418641a/RELEASE_NOTES
----------------------------------------------------------------------
diff --git a/RELEASE_NOTES b/RELEASE_NOTES
index 7edf235..5aaadc3 100644
--- a/RELEASE_NOTES
+++ b/RELEASE_NOTES
@@ -54,6 +54,7 @@ FLEX-33311 Null pointer fatal in ConstraintLayout when executing Transition on
FLEX-33058 RTE in HierarchicalCollectionViewCursor when a refresh occurs and old cursor
had an enumerable property that new cursor item doesn't
FLEX-31948 When all the columns are invisible, pressing any character Key throws RTE
+FLEX-27509 AdvancedListBase itemMaskFreeList is null
FLEX-26808 s:DataGrid Drag and Drop of multiple items doesn't work
FLEX-20313 SelectItem on AdvancedDataGrid use weird code