You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/13 16:10:34 UTC

[GitHub] [kafka] bertber opened a new pull request #9742: MINOR: Add a test for ByteBufferInputStream to ByteBufferLogInputStreamTest

bertber opened a new pull request #9742:
URL: https://github.com/apache/kafka/pull/9742


   I made a test for ByteBufferInputStream in the ByteBufferLogInputStreamTest.
   First, I add a ByteBuffer that it's mot empty to the ByteBufferInputStream, in order to verify it.
   After that, I try to use ByteBufferInputStream's read function and check return value whether it's correct.
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] bertber closed pull request #9742: KAFKA-10768 Add a test for ByteBufferInputStream to ByteBufferLogInputStreamTest

Posted by GitBox <gi...@apache.org>.
bertber closed pull request #9742:
URL: https://github.com/apache/kafka/pull/9742


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on a change in pull request #9742: MINOR: Add a test for ByteBufferInputStream to ByteBufferLogInputStreamTest

Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9742:
URL: https://github.com/apache/kafka/pull/9742#discussion_r542219427



##########
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##########
@@ -489,19 +489,7 @@ public void resetOffsetsFromResetPlan(final Consumer<byte[], byte[]> client,
     private void resetByDuration(final Consumer<byte[], byte[]> client,
                                  final Set<TopicPartition> inputTopicPartitions,
                                  final Duration duration) {
-        final Instant now = Instant.now();

Review comment:
       Please don't include other commit code




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org