You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "sean schofield (JIRA)" <in...@incubator.apache.org> on 2005/01/21 20:44:20 UTC
[jira] Created: (MYFACES-85) Non-standard attributes in the html taglibs
Non-standard attributes in the html taglibs
-------------------------------------------
Key: MYFACES-85
URL: http://issues.apache.org/jira/browse/MYFACES-85
Project: MyFaces
Type: Bug
Versions: 1.0.7 beta, 1.0.8 beta
Reporter: sean schofield
I noticed that some of the extended attributes have crept into the standard HTML taglibs. For instance, you can set a property of transient on <h:form>. These should be limited to the extended HTML tags only. I believe they are just ignored in the standard case but they should not be in the TLD. IDE tools like JBuilder also show these as available attributes which is incorrect.
So far I've identified transient and the new forceId attribute. forceId is there because I was basically following the pattern of transient. Both are defined in the 'ui_component_attributes.xml' file which I believe applies to all of the HTML tags (both standard and extended.) This should be changed so that they only apply to the correct extended tags that actually support the properties. (There is already a comment in that file questioning the appropriateness of using the attribute here so apparently at least someone else already agrees with me on this.)
I will try to work on a patch for forceId shortly. The person responsible for the transient property might want to patch that one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-85) Non-standard attributes in the html taglibs
Posted by "sean schofield (JIRA)" <in...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-85?page=history ]
sean schofield updated MYFACES-85:
----------------------------------
Attachment: forceIdAttribute.patch
> Non-standard attributes in the html taglibs
> -------------------------------------------
>
> Key: MYFACES-85
> URL: http://issues.apache.org/jira/browse/MYFACES-85
> Project: MyFaces
> Type: Bug
> Versions: 1.0.7 beta, 1.0.8 beta
> Reporter: sean schofield
> Attachments: ext_forceId_attribute.xml, forceIdAttribute.patch
>
> I noticed that some of the extended attributes have crept into the standard HTML taglibs. For instance, you can set a property of transient on <h:form>. These should be limited to the extended HTML tags only. I believe they are just ignored in the standard case but they should not be in the TLD. IDE tools like JBuilder also show these as available attributes which is incorrect.
> So far I've identified transient and the new forceId attribute. forceId is there because I was basically following the pattern of transient. Both are defined in the 'ui_component_attributes.xml' file which I believe applies to all of the HTML tags (both standard and extended.) This should be changed so that they only apply to the correct extended tags that actually support the properties. (There is already a comment in that file questioning the appropriateness of using the attribute here so apparently at least someone else already agrees with me on this.)
> I will try to work on a patch for forceId shortly. The person responsible for the transient property might want to patch that one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-85) Non-standard attributes in the html taglibs
Posted by "sean schofield (JIRA)" <in...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-85?page=history ]
sean schofield updated MYFACES-85:
----------------------------------
Attachment: transient.patch
This patch removes the transient attribute completely. Manfred said this was legacy code from the early days and was ok to remove. Once patch is applied bug should be considered resolved/fixed.
> Non-standard attributes in the html taglibs
> -------------------------------------------
>
> Key: MYFACES-85
> URL: http://issues.apache.org/jira/browse/MYFACES-85
> Project: MyFaces
> Type: Bug
> Versions: 1.0.7 beta, 1.0.8 beta
> Reporter: sean schofield
> Assignee: Matthias Weßendorf
> Attachments: ext_forceId_attribute.xml, forceIdAttribute.patch, transient.patch
>
> I noticed that some of the extended attributes have crept into the standard HTML taglibs. For instance, you can set a property of transient on <h:form>. These should be limited to the extended HTML tags only. I believe they are just ignored in the standard case but they should not be in the TLD. IDE tools like JBuilder also show these as available attributes which is incorrect.
> So far I've identified transient and the new forceId attribute. forceId is there because I was basically following the pattern of transient. Both are defined in the 'ui_component_attributes.xml' file which I believe applies to all of the HTML tags (both standard and extended.) This should be changed so that they only apply to the correct extended tags that actually support the properties. (There is already a comment in that file questioning the appropriateness of using the attribute here so apparently at least someone else already agrees with me on this.)
> I will try to work on a patch for forceId shortly. The person responsible for the transient property might want to patch that one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
[jira] Updated: (MYFACES-85) Non-standard attributes in the html taglibs
Posted by "sean schofield (JIRA)" <in...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-85?page=history ]
sean schofield updated MYFACES-85:
----------------------------------
Attachment: ext_forceId_attribute.xml
New entity file for the forceId attribute (this is conjunction with the patch should fix the problem for forceId attribute.) Transient attribute still needs to be addressed (I am hoping the person who know transient best will step forward ...)
> Non-standard attributes in the html taglibs
> -------------------------------------------
>
> Key: MYFACES-85
> URL: http://issues.apache.org/jira/browse/MYFACES-85
> Project: MyFaces
> Type: Bug
> Versions: 1.0.7 beta, 1.0.8 beta
> Reporter: sean schofield
> Attachments: ext_forceId_attribute.xml, forceIdAttribute.patch
>
> I noticed that some of the extended attributes have crept into the standard HTML taglibs. For instance, you can set a property of transient on <h:form>. These should be limited to the extended HTML tags only. I believe they are just ignored in the standard case but they should not be in the TLD. IDE tools like JBuilder also show these as available attributes which is incorrect.
> So far I've identified transient and the new forceId attribute. forceId is there because I was basically following the pattern of transient. Both are defined in the 'ui_component_attributes.xml' file which I believe applies to all of the HTML tags (both standard and extended.) This should be changed so that they only apply to the correct extended tags that actually support the properties. (There is already a comment in that file questioning the appropriateness of using the attribute here so apparently at least someone else already agrees with me on this.)
> I will try to work on a patch for forceId shortly. The person responsible for the transient property might want to patch that one.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira