You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/07 15:10:11 UTC
[GitHub] [camel-website] CSElonewolf opened a new pull request #171: updated
the the stroke-opacity and animation delay
CSElonewolf opened a new pull request #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171
[CAMEL-14676](https://issues.apache.org/jira/browse/CAMEL-14676)
Changes were made for making the swoosh design more apparent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #171: updated the
the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596220061
<img width="960" alt="new issue" src="https://user-images.githubusercontent.com/51082429/76166097-e6dadd00-6181-11ea-82c9-d32be74c5089.png">
I have noticed that the right-side nabvar-item section has does not highlight the visited link like the left-side user manual section does.Therefore I thought of adding a css.
The only extra changes that needs to be done is to add the ".is-current-page" class in the <div> section containing the "is-hoverable" class.
please review the commit nad let me know
@zregvart and @oscerd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf edited a comment on issue #171: updated
the the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf edited a comment on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596220061
<img width="960" alt="new issue" src="https://user-images.githubusercontent.com/51082429/76166500-fdcefe80-6184-11ea-9626-1b35e13eb148.png">
I have noticed that the right-side nabvar-item section does not highlight the visited link like the left-side user manual section does.Therefore I thought of adding a css.
The only extra changes that needs to be done is to add the ".is-current-page" class in the `<div>` section containing the "is-hoverable" class.
please review the commit nad let me know
@zregvart and @oscerd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf edited a comment on issue #171: updated
the the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf edited a comment on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596220061
`<img` width="960" alt="new issue" src="https://user-images.githubusercontent.com/51082429/76166097-e6dadd00-6181-11ea-82c9-d32be74c5089.png">
I have noticed that the right-side nabvar-item section has does not highlight the visited link like the left-side user manual section does.Therefore I thought of adding a css.
The only extra changes that needs to be done is to add the ".is-current-page" class in the `<div>` section containing the "is-hoverable" class.
please review the commit nad let me know
@zregvart and @oscerd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #171: updated the the
stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596418108
@CSElonewolf perhaps you can include just the first commit you made ce577e929d76aa1706b4db85050f91ff836fc4fd by doing a `git reset ce577e929d76aa1706b4db85050f91ff836fc4fd` followed by `git push --force`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf edited a comment on issue #171: updated
the the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf edited a comment on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596220061
<img width="960" alt="new issue" src="https://user-images.githubusercontent.com/51082429/76166500-fdcefe80-6184-11ea-9626-1b35e13eb148.png">
I have noticed that the right-side nabvar-item section has does not highlight the visited link like the left-side user manual section does.Therefore I thought of adding a css.
The only extra changes that needs to be done is to add the ".is-current-page" class in the `<div>` section containing the "is-hoverable" class.
please review the commit nad let me know
@zregvart and @oscerd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #171: updated the
the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596398217
> Thank you, the swoosh animation does look more apparent now. Here's the [preview](https://builds.apache.org/job/Camel.website/job/PR-171/Preview/index.html).
>
> We like to keep our changes on topic, so I would prefer that the changes in [75798bd](https://github.com/apache/camel-website/commit/75798bd535d45e5edaa167d8ed45a5770ac6faa4) are done on a separate pull request if possible.
>
> And with regards to that change the CSS lint is reporting two issues:
>
> ```
> 17:38:30 src/css/header.css
> 17:38:30 371:1 ✖ Expected empty line before rule rule-empty-line-before
> 17:38:30 373:2 ✖ Unexpected whitespace at end of line no-eol-whitespace
> ```
>
> You can run the build locally in the `antora-ui-camel` directory by doing `yarn build` there to make sure changes do not introduce lint errors.
The preview looks awesome.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf removed a comment on issue #171:
updated the the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf removed a comment on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596220061
<img width="960" alt="new issue" src="https://user-images.githubusercontent.com/51082429/76166500-fdcefe80-6184-11ea-9626-1b35e13eb148.png">
I have noticed that the right-side nabvar-item section does not highlight the visited link like the left-side user manual section does.Therefore I thought of adding a css.
The only extra changes that needs to be done is to add the ".is-current-page" class in the `<div>` section containing the "is-hoverable" class.
please review the commit nad let me know
@zregvart and @oscerd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf edited a comment on issue #171: updated
the the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf edited a comment on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596473358
@zregvart actually the file that contains the css to make changes aare present in `antora-ui-camel/src/css/frontpage.css`.
My very first commit.Ok.I am closing this PR and making a new.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #171: updated the the
stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596469971
@CSElonewolf you deleted the whole file `antora-ui-camel/src/css/header.css` which contains CSS styling we need, not just the changes you made. You can see on the [Files changed](https://github.com/apache/camel-website/pull/171/files) tab that the whole file was deleted.
If you're using GitHub user interface to create pull request then I don't think you can remove commits from the pull request, so it might be easier for you to close this one and create a new pull request with the change you intended.
If you're using the `git` command line then doing `git reset` followed by `git push` as commented above will do that for this pull request.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf edited a comment on issue #171: updated
the the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf edited a comment on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596424602
@zregvart Actually I deleted the [75798bd](https://github.com/apache/camel-website/pull/171/commits/75798bd535d45e5edaa167d8ed45a5770ac6faa4)
commit.
But even if there is any problem in merging the PR.I can close this PR and open a new one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf closed pull request #171: updated the
the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf closed pull request #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #171: updated the
the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596181642
Thanks @oscerd for taking your time to approve my commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] zregvart commented on issue #171: updated the the
stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
zregvart commented on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596391802
Thank you, the swoosh animation does look more apparent now. Here's the [preview](https://builds.apache.org/job/Camel.website/job/PR-171/Preview/index.html).
We like to keep our changes on topic, so I would prefer that the changes in 75798bd535d45e5edaa167d8ed45a5770ac6faa4 are done on a separate pull request if possible.
And with regards to that change the CSS lint is reporting two issues:
```
17:38:30 src/css/header.css
17:38:30 371:1 ✖ Expected empty line before rule rule-empty-line-before
17:38:30 373:2 ✖ Unexpected whitespace at end of line no-eol-whitespace
```
You can run the build locally in the `antora-ui-camel` directory by doing `yarn build` there to make sure changes do not introduce lint errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #171: updated the
the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596424602
@zregvart Actually I deleted the [75798bd](https://github.com/apache/camel-website/pull/171/commits/75798bd535d45e5edaa167d8ed45a5770ac6faa4)
commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #171: updated the
the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596473358
@zregvart actually the file that contains the css to make changes aare present in `antora-ui-camel/src/css/frontpage.css`.
My very first commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-website] CSElonewolf commented on issue #171: updated the
the stroke-opacity and animation delay
Posted by GitBox <gi...@apache.org>.
CSElonewolf commented on issue #171: updated the the stroke-opacity and animation delay
URL: https://github.com/apache/camel-website/pull/171#issuecomment-596395718
@zregvart I will definitely keep that in mind and I will be definitely pull requesting separately.Because being an Outreachy applicant and open source lover.I would love to contribute for the betterment of the site. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services