You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/10 20:30:47 UTC

[GitHub] [nuttx] gustavonihei commented on a diff in pull request #8075: Minor fs/mmap improvement

gustavonihei commented on code in PR #8075:
URL: https://github.com/apache/nuttx/pull/8075#discussion_r1066296367


##########
fs/mmap/fs_anonmap.c:
##########
@@ -39,32 +39,69 @@ static int unmap_anonymous(FAR struct task_group_s *group,
                            FAR void *start,
                            size_t length)
 {
-  int ret;
+  FAR void *newaddr;

Review Comment:
   ```suggestion
     FAR void *newaddr unused_data;
   ```
   nit: An alternative to the `UNUSED(newaddr)` in line 103 is the `unused` attribute, which indicates that the variable might not be used, preventing a compiler warning. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org