You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Patrick Mueller (Created) (JIRA)" <ji...@apache.org> on 2012/02/21 00:13:34 UTC
[jira] [Created] (CB-269) tests require too many globally installed
node packages
tests require too many globally installed node packages
-------------------------------------------------------
Key: CB-269
URL: https://issues.apache.org/jira/browse/CB-269
Project: Apache Callback
Issue Type: Bug
Components: CordovaJS
Reporter: Patrick Mueller
Just noticed that {{jake test}} fails if you don't have the npm package {{jsdom}} globally installed.
I know there are more of these lurking. We shouldn't have *ANY* requirements for globally installed packages.
Instead, we should reference all the packages we need in the {{package.json}} dependencies (or maybe devDependencies) value, and then we can "auto-install" them by just running "{{npm install}}".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (CB-269) cordova-js requires too many
globally installed node packages to do anything
Posted by Filip Maj <fi...@adobe.com>.
Trying to push this fix to apache git servers but seems they are down...
On 12-02-22 2:38 PM, "Patrick Mueller" <pm...@gmail.com> wrote:
>On Wed, Feb 22, 2012 at 16:53, Gord Tanner <go...@tinyhippos.com> wrote:
>
>> this is why I wanted to have jake installed globally ;)
>>
>> Since it you should be able to run jake in any subdirectory of the
>>project
>> and it will build as well ;)
>>
>> Build tools should be global IMHO
>>
>
>k. Let's remove jake from the package.json, and then add to the README
>that
>you need to have jake installed globally, and list the version we're using
>(I'm thinking it hasn't changed in forevar).
>
>--
>Patrick Mueller
>http://muellerware.org
Re: [jira] [Commented] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by Patrick Mueller <pm...@gmail.com>.
On Wed, Feb 22, 2012 at 16:53, Gord Tanner <go...@tinyhippos.com> wrote:
> this is why I wanted to have jake installed globally ;)
>
> Since it you should be able to run jake in any subdirectory of the project
> and it will build as well ;)
>
> Build tools should be global IMHO
>
k. Let's remove jake from the package.json, and then add to the README that
you need to have jake installed globally, and list the version we're using
(I'm thinking it hasn't changed in forevar).
--
Patrick Mueller
http://muellerware.org
Re: [jira] [Commented] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by Gord Tanner <go...@tinyhippos.com>.
Yeah,
this is why I wanted to have jake installed globally ;)
Since it you should be able to run jake in any subdirectory of the project
and it will build as well ;)
Build tools should be global IMHO
On Wed, Feb 22, 2012 at 4:39 PM, Patrick Mueller (Commented) (JIRA) <
jira@apache.org> wrote:
>
> [
> https://issues.apache.org/jira/browse/CB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214020#comment-13214020]
>
> Patrick Mueller commented on CB-269:
> ------------------------------------
>
> So, now that jake is installed in node_modules via the `npm install`, the
> way you need to invoke it is :
>
> {noformat}
> ./node_modules/.bin/jake blah
> {noformat}
>
> Tempted to just say "we assume you have jake installed, but if you don't,
> you can globally install it via `npm -g install jake`."
>
> That, or we create a jake shim script in the base directory:
>
> {noformat}
> #!/bin/sh
> `dirname $0`/node_modules/.bin/jake $*
> {noformat}
>
>
> > cordova-js requires too many globally installed node packages to do
> anything
> >
> ----------------------------------------------------------------------------
> >
> > Key: CB-269
> > URL: https://issues.apache.org/jira/browse/CB-269
> > Project: Apache Callback
> > Issue Type: Bug
> > Components: CordovaJS
> > Reporter: Patrick Mueller
> > Assignee: Filip Maj
> > Fix For: 1.5.0
> >
> >
> > Just noticed that {{jake test}} fails if you don't have the npm package
> {{jsdom}} globally installed.
> > I know there are more of these lurking. We shouldn't have *ANY*
> requirements for globally installed packages.
> > Instead, we should reference all the packages we need in the
> {{package.json}} dependencies (or maybe devDependencies) value, and then we
> can "auto-install" them by just running "{{npm install}}".
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
--
Gord Tanner
Senior Developer / Code Poet
tinyHippos Inc.
@tinyhippos
Re: [jira] [Commented] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by Patrick Mueller <pm...@gmail.com>.
On Mon, Feb 20, 2012 at 19:12, <gt...@gmail.com> wrote:
> I usually install node to my home folder so I don't need to sudo.
>
Hmm, hadn't considered that, sounds kinda interesting. But I think we have
to assume that folks might have it installed "globally", and then the npm
-g installs won't really work. We can't FORCE people to install node
"locally", can we?
> I would argue that jake should be global since it is a build tool, much
> like make or rake.
>
I don't see why a build tool needs to be installed globally. If we install
ANYTHING globally, then we're opening up the possibility of folks
inadvertently installing/uninstalling/upgrading things that we depend on.
Not great.
--
Patrick Mueller
http://muellerware.org
Re: [jira] [Commented] (CB-269) cordova-js requires too many globally installed node packages to do anything
Posted by gt...@gmail.com.
I usually install node to my home folder so I don't need to sudo.
I would argue that jake should be global since it is a build tool, much like make or rake.
Sent on the TELUS Mobility network with BlackBerry
-----Original Message-----
From: "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>
Date: Tue, 21 Feb 2012 00:05:34
To: <ca...@incubator.apache.org>
Reply-To: callback-dev@incubator.apache.org
Subject: [jira] [Commented] (CB-269) cordova-js requires too many globally
installed node packages to do anything
[ https://issues.apache.org/jira/browse/CB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212234#comment-13212234 ]
Patrick Mueller commented on CB-269:
------------------------------------
Actually, it appears some (all) of the requirements are handled via the '{{configure}}' script.
Jake is installed globally, but shouldn't be - in fact, that invocation won't work, unless you run {{configure}} under sudo anyway.
> cordova-js requires too many globally installed node packages to do anything
> ----------------------------------------------------------------------------
>
> Key: CB-269
> URL: https://issues.apache.org/jira/browse/CB-269
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
>
> Just noticed that {{jake test}} fails if you don't have the npm package {{jsdom}} globally installed.
> I know there are more of these lurking. We shouldn't have *ANY* requirements for globally installed packages.
> Instead, we should reference all the packages we need in the {{package.json}} dependencies (or maybe devDependencies) value, and then we can "auto-install" them by just running "{{npm install}}".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214020#comment-13214020 ]
Patrick Mueller commented on CB-269:
------------------------------------
So, now that jake is installed in node_modules via the `npm install`, the way you need to invoke it is :
{noformat}
./node_modules/.bin/jake blah
{noformat}
Tempted to just say "we assume you have jake installed, but if you don't, you can globally install it via `npm -g install jake`."
That, or we create a jake shim script in the base directory:
{noformat}
#!/bin/sh
`dirname $0`/node_modules/.bin/jake $*
{noformat}
> cordova-js requires too many globally installed node packages to do anything
> ----------------------------------------------------------------------------
>
> Key: CB-269
> URL: https://issues.apache.org/jira/browse/CB-269
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
> Assignee: Filip Maj
> Fix For: 1.5.0
>
>
> Just noticed that {{jake test}} fails if you don't have the npm package {{jsdom}} globally installed.
> I know there are more of these lurking. We shouldn't have *ANY* requirements for globally installed packages.
> Instead, we should reference all the packages we need in the {{package.json}} dependencies (or maybe devDependencies) value, and then we can "auto-install" them by just running "{{npm install}}".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by "Filip Maj (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212991#comment-13212991 ]
Filip Maj commented on CB-269:
------------------------------
Agreed, I will move all dependencies over to package.json and update the README accordingly.
> cordova-js requires too many globally installed node packages to do anything
> ----------------------------------------------------------------------------
>
> Key: CB-269
> URL: https://issues.apache.org/jira/browse/CB-269
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
> Assignee: Filip Maj
>
> Just noticed that {{jake test}} fails if you don't have the npm package {{jsdom}} globally installed.
> I know there are more of these lurking. We shouldn't have *ANY* requirements for globally installed packages.
> Instead, we should reference all the packages we need in the {{package.json}} dependencies (or maybe devDependencies) value, and then we can "auto-install" them by just running "{{npm install}}".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13212234#comment-13212234 ]
Patrick Mueller commented on CB-269:
------------------------------------
Actually, it appears some (all) of the requirements are handled via the '{{configure}}' script.
Jake is installed globally, but shouldn't be - in fact, that invocation won't work, unless you run {{configure}} under sudo anyway.
> cordova-js requires too many globally installed node packages to do anything
> ----------------------------------------------------------------------------
>
> Key: CB-269
> URL: https://issues.apache.org/jira/browse/CB-269
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
>
> Just noticed that {{jake test}} fails if you don't have the npm package {{jsdom}} globally installed.
> I know there are more of these lurking. We shouldn't have *ANY* requirements for globally installed packages.
> Instead, we should reference all the packages we need in the {{package.json}} dependencies (or maybe devDependencies) value, and then we can "auto-install" them by just running "{{npm install}}".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by "Patrick Mueller (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213880#comment-13213880 ]
Patrick Mueller commented on CB-269:
------------------------------------
Looks good (just browsing it), but the list of individual committers in the package.json isn't required or desired, I don't think. Can we just use "Apache"?
> cordova-js requires too many globally installed node packages to do anything
> ----------------------------------------------------------------------------
>
> Key: CB-269
> URL: https://issues.apache.org/jira/browse/CB-269
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
> Assignee: Filip Maj
> Fix For: 1.5.0
>
>
> Just noticed that {{jake test}} fails if you don't have the npm package {{jsdom}} globally installed.
> I know there are more of these lurking. We shouldn't have *ANY* requirements for globally installed packages.
> Instead, we should reference all the packages we need in the {{package.json}} dependencies (or maybe devDependencies) value, and then we can "auto-install" them by just running "{{npm install}}".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by "Filip Maj (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13213888#comment-13213888 ]
Filip Maj commented on CB-269:
------------------------------
I don't care either way but figured the original author (Gord) plus some of the other contributors would appreciate attribution. If you think it shouldn't be there - axe it!
> cordova-js requires too many globally installed node packages to do anything
> ----------------------------------------------------------------------------
>
> Key: CB-269
> URL: https://issues.apache.org/jira/browse/CB-269
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
> Assignee: Filip Maj
> Fix For: 1.5.0
>
>
> Just noticed that {{jake test}} fails if you don't have the npm package {{jsdom}} globally installed.
> I know there are more of these lurking. We shouldn't have *ANY* requirements for globally installed packages.
> Instead, we should reference all the packages we need in the {{package.json}} dependencies (or maybe devDependencies) value, and then we can "auto-install" them by just running "{{npm install}}".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by "Filip Maj (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj resolved CB-269.
--------------------------
Resolution: Fixed
Fix Version/s: 1.5.0
Fixed in [aeffdf3|http://git-wip-us.apache.org/repos/asf?p=incubator-cordova-js.git;a=commit;h=aeffdf3a12ee2b0b2a19301dbfd6f794f7834473]
> cordova-js requires too many globally installed node packages to do anything
> ----------------------------------------------------------------------------
>
> Key: CB-269
> URL: https://issues.apache.org/jira/browse/CB-269
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
> Assignee: Filip Maj
> Fix For: 1.5.0
>
>
> Just noticed that {{jake test}} fails if you don't have the npm package {{jsdom}} globally installed.
> I know there are more of these lurking. We shouldn't have *ANY* requirements for globally installed packages.
> Instead, we should reference all the packages we need in the {{package.json}} dependencies (or maybe devDependencies) value, and then we can "auto-install" them by just running "{{npm install}}".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by "Filip Maj (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj reassigned CB-269:
----------------------------
Assignee: Filip Maj
> cordova-js requires too many globally installed node packages to do anything
> ----------------------------------------------------------------------------
>
> Key: CB-269
> URL: https://issues.apache.org/jira/browse/CB-269
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
> Assignee: Filip Maj
>
> Just noticed that {{jake test}} fails if you don't have the npm package {{jsdom}} globally installed.
> I know there are more of these lurking. We shouldn't have *ANY* requirements for globally installed packages.
> Instead, we should reference all the packages we need in the {{package.json}} dependencies (or maybe devDependencies) value, and then we can "auto-install" them by just running "{{npm install}}".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CB-269) cordova-js requires too many globally
installed node packages to do anything
Posted by "Patrick Mueller (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CB-269?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Mueller updated CB-269:
-------------------------------
Summary: cordova-js requires too many globally installed node packages to do anything (was: tests require too many globally installed node packages)
> cordova-js requires too many globally installed node packages to do anything
> ----------------------------------------------------------------------------
>
> Key: CB-269
> URL: https://issues.apache.org/jira/browse/CB-269
> Project: Apache Callback
> Issue Type: Bug
> Components: CordovaJS
> Reporter: Patrick Mueller
>
> Just noticed that {{jake test}} fails if you don't have the npm package {{jsdom}} globally installed.
> I know there are more of these lurking. We shouldn't have *ANY* requirements for globally installed packages.
> Instead, we should reference all the packages we need in the {{package.json}} dependencies (or maybe devDependencies) value, and then we can "auto-install" them by just running "{{npm install}}".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira