You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "BlueRui (via GitHub)" <gi...@apache.org> on 2024/01/12 00:40:49 UTC

[PR] Filename fix 491 [directory-scimple]

BlueRui opened a new pull request, #492:
URL: https://github.com/apache/directory-scimple/pull/492

   - Colons are not accepted in file names on Windows causing error when checking out this project. The change replaces the colons with underscores in test resource file names.
   - Updated affected test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org

Re: [PR] Remove colons from test schema file name [directory-scimple]

Posted by "mattiahj (via GitHub)" <gi...@apache.org>.
mattiahj commented on PR #492:
URL: https://github.com/apache/directory-scimple/pull/492#issuecomment-1905476481

   @bdemers Can this be merged?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org

Re: [PR] Remove colons from test schema file name [directory-scimple]

Posted by "BlueRui (via GitHub)" <gi...@apache.org>.
BlueRui commented on code in PR #492:
URL: https://github.com/apache/directory-scimple/pull/492#discussion_r1454437151


##########
scim-spec/scim-spec-schema/src/test/java/org/apache/directory/scim/spec/schema/SchemaTest.java:
##########
@@ -60,12 +60,12 @@ public void setUp() {
    */
   @ParameterizedTest
   @ValueSource( strings = {
-      "schemas/urn:ietf:params:scim:schemas:core:2.0:User.json",
-      "schemas/urn:ietf:params:scim:schemas:core:2.0:Group.json",
-      "schemas/urn:ietf:params:scim:schemas:core:2.0:ResourceType.json",
-      "schemas/urn:ietf:params:scim:schemas:core:2.0:Schema.json",
-      "schemas/urn:ietf:params:scim:schemas:core:2.0:ServiceProviderConfig.json",
-      "schemas/urn:ietf:params:scim:schemas:extension:enterprise:2.0:User.json"
+      "schemas/urn_ietf_params_scim_schemas_core_2.0_User.json",
+      "schemas/urn_ietf_params_scim_schemas_core_2.0_Group.json",
+      "schemas/urn_ietf_params_scim_schemas_core_2.0_ResourceType.json",
+      "schemas/urn_ietf_params_scim_schemas_core_2.0_Schema.json",
+      "schemas/urn_ietf_params_scim_schemas_core_2.0_ServiceProviderConfig.json",
+      "schemas/urn_ietf_params_scim_schemas_extension_enterprise_2.0_User.json"

Review Comment:
   Updated file names



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org

Re: [PR] Remove colons from test schema file name [directory-scimple]

Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on PR #492:
URL: https://github.com/apache/directory-scimple/pull/492#issuecomment-1906199546

   Yup! I'm on it!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org

Re: [PR] Filename fix 491 [directory-scimple]

Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers commented on code in PR #492:
URL: https://github.com/apache/directory-scimple/pull/492#discussion_r1454154644


##########
scim-spec/scim-spec-schema/src/test/java/org/apache/directory/scim/spec/schema/SchemaTest.java:
##########
@@ -60,12 +60,12 @@ public void setUp() {
    */
   @ParameterizedTest
   @ValueSource( strings = {
-      "schemas/urn:ietf:params:scim:schemas:core:2.0:User.json",
-      "schemas/urn:ietf:params:scim:schemas:core:2.0:Group.json",
-      "schemas/urn:ietf:params:scim:schemas:core:2.0:ResourceType.json",
-      "schemas/urn:ietf:params:scim:schemas:core:2.0:Schema.json",
-      "schemas/urn:ietf:params:scim:schemas:core:2.0:ServiceProviderConfig.json",
-      "schemas/urn:ietf:params:scim:schemas:extension:enterprise:2.0:User.json"
+      "schemas/urn_ietf_params_scim_schemas_core_2.0_User.json",
+      "schemas/urn_ietf_params_scim_schemas_core_2.0_Group.json",
+      "schemas/urn_ietf_params_scim_schemas_core_2.0_ResourceType.json",
+      "schemas/urn_ietf_params_scim_schemas_core_2.0_Schema.json",
+      "schemas/urn_ietf_params_scim_schemas_core_2.0_ServiceProviderConfig.json",
+      "schemas/urn_ietf_params_scim_schemas_extension_enterprise_2.0_User.json"

Review Comment:
   Can you remove the prefix?
   If the string no longer represents the URN, it could be any string:
   
   ```suggestion
         "schemas/User.json",
         "schemas/Group.json",
         "schemas/ResourceType.json",
         "schemas/Schema.json",
         "schemas/ServiceProviderConfig.json",
         "schemas/EnterpriseUser.json"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org

Re: [PR] Remove colons from test schema file name [directory-scimple]

Posted by "bdemers (via GitHub)" <gi...@apache.org>.
bdemers merged PR #492:
URL: https://github.com/apache/directory-scimple/pull/492


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org