You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/17 21:09:17 UTC

[GitHub] [arrow-datafusion] jdye64 commented on a diff in pull request #2564: Introduce Expr.variant_name() function

jdye64 commented on code in PR #2564:
URL: https://github.com/apache/arrow-datafusion/pull/2564#discussion_r875263708


##########
datafusion/expr/src/expr.rs:
##########
@@ -294,6 +294,40 @@ impl Expr {
         create_name(self, input_schema)
     }
 
+    /// Return String representation of the variant represented by `self`
+    /// Useful for non-rust based bindings
+    pub fn variant_name(self) -> Result<String> {
+        Ok(String::from(match &self {

Review Comment:
   Should this maybe just be a `String` return type and not `Result<String>`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org