[GitHub] [incubator-streampark] macksonmu commented on a diff in pull request #1866: [Feature] Reference variables as placeholders in program args and Flink SQL

[GitBox <gi...@apache.org>]

macksonmu commented on code in PR #1866:
URL: https://github.com/apache/incubator-streampark/pull/1866#discussion_r1001862564


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/core/entity/Variable.java:
##########
@@ -42,7 +42,6 @@ public class Variable implements Serializable {
     private String variableCode;
 
     @NotBlank(message = "{required}")
-    @Size(max = 50, message = "{noMoreThan}")

Review Comment:
   I added the real variables of the production system and found that 50 characters are really not enough. For example, a kafka cluster has 20 ips



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org