[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2668: Kernel module should prefer functions with nx/kmm prefix

[GitBox <gi...@apache.org>]

Ouss4 commented on a change in pull request #2668:
URL: https://github.com/apache/incubator-nuttx/pull/2668#discussion_r555875128



##########
File path: arch/xtensa/src/esp32/esp32_wifi_adapter.c
##########
@@ -1841,7 +1841,7 @@ static int32_t esp_task_get_max_priority(void)
 
 static void *esp_malloc(uint32_t size)
 {
-  return malloc(size);
+  return kmm_malloc(size);

Review comment:
       Could please also change the `_free` member of the `g_wifi_osi_funcs` structure from `free` to `kmm_free`.
   
   There are actually a few other violation of the sort in this file, especially around files management.  We had an internal PR that addressed all of those but it has stalled for other reasons.
   Will fix more in the upcoming days.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org