[GitHub] [skywalking-java] tjiuming commented on pull request #405: [fix][plugin][pulsar] Clean message context after message is recycled to prevent memory leak.

[GitBox <gi...@apache.org>]

tjiuming commented on PR #405:
URL: https://github.com/apache/skywalking-java/pull/405#issuecomment-1340851003

   > > The MessageImpl will not GC by JVM, so the new MessageEnhanceRequiredInfo() settled into MessageImpl won't be GC too, it will lead to memory leak.
   > 
   > If you mean `MessageImpl` objects are pooled, then the current codes could lead to dirty data. But leak? I doubt that.
   
   in my opinion, I just feeling that release the tracing context as soon as the message recycled will be helpful to saving the heap memory. 
   My words are wrong, it's not memory leak, because the MessageImpl is reachable and usable.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org