[jira] Commented: (SANDBOX-260) ASM bytecode transformation let verification from JVM fail for some method (-signatures)

["Valery Silaev (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SANDBOX-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12793797#action_12793797 ] 

Valery Silaev commented on SANDBOX-260:
---------------------------------------

it seems that patch sent by Claas has an error in test case (please refer to AbstractRewriteBugsTestCase in attached patch):

this is incorrect:
RewriteBugs.calculateCartesianProduct(new String[]{"a","b"}, new Object[]{"1","2"}); 

this is correct:
RewriteBugs.calculateCartesianProduct(new String[]{"a","b"}, new Object[][]{{"1","2"}, {"3", "4"}});

But nevertheless, I've re-tested this example (with fix mentioned above to test case) and it works with revision 893171 and ASM 3.1 / 3.2

> ASM bytecode transformation let verification from JVM fail for some method (-signatures)
> ----------------------------------------------------------------------------------------
>
>                 Key: SANDBOX-260
>                 URL: https://issues.apache.org/jira/browse/SANDBOX-260
>             Project: Commons Sandbox
>          Issue Type: Bug
>          Components: Javaflow
>         Environment: Sun JDK 1.5 / 1.6, 
> 64bit / 32bit emul.
> asm 2.2.3
>            Reporter: Claas Altschaffel
>         Attachments: ASMRewriteBugsTestCase.patch
>
>
> I think there is a bug in the asm bytecode transformer (considered as "experimental"?).
> The transformer transforms some methods into bytecode which seems to be not valid. The ASM CheckClassAdapter and the JVM-Verifier fails to check the transformed class with a VerifyError.
> I will provide a TestCase to show this problem.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.