You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/10/21 08:17:33 UTC
[GitHub] [camel-quarkus] zbendhiba opened a new pull request #1938: Lumberjack native support fixes #1732
zbendhiba opened a new pull request #1938:
URL: https://github.com/apache/camel-quarkus/pull/1938
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #1938: Lumberjack native support fixes #1732
Posted by GitBox <gi...@apache.org>.
ppalaga merged pull request #1938:
URL: https://github.com/apache/camel-quarkus/pull/1938
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on a change in pull request #1938: Lumberjack native support fixes #1732
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on a change in pull request #1938:
URL: https://github.com/apache/camel-quarkus/pull/1938#discussion_r509229708
##########
File path: integration-tests/lumberjack/pom.xml
##########
@@ -51,6 +51,14 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-bean</artifactId>
Review comment:
done !!
thanks !!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull request #1938: Lumberjack native support fixes #1732
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #1938:
URL: https://github.com/apache/camel-quarkus/pull/1938#discussion_r509161065
##########
File path: integration-tests/lumberjack/pom.xml
##########
@@ -51,6 +51,14 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-resteasy</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-bean</artifactId>
Review comment:
Whenever you add camel extension dependencies into the itest pom, please run `mvn process-resources -Pformat -N` from the project root to regenerate the set of imported pom dependencies (E.g the stuff under the `The following dependencies guarantee that this module is built after them` comment).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #1938: Lumberjack native support fixes #1732
Posted by GitBox <gi...@apache.org>.
ppalaga commented on pull request #1938:
URL: https://github.com/apache/camel-quarkus/pull/1938#issuecomment-713403129
Could we perhaps add some (e.g. `.bin` ) extension to the `window*` files so that we can easily exclude them from license checking around here https://github.com/apache/camel-quarkus/blob/master/pom.xml#L406-L416 ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zbendhiba commented on pull request #1938: Lumberjack native support fixes #1732
Posted by GitBox <gi...@apache.org>.
zbendhiba commented on pull request #1938:
URL: https://github.com/apache/camel-quarkus/pull/1938#issuecomment-713411105
@ppalaga I've changed to .bin and added <exclude>**/*.bin</exclude> in pom parent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org