You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2016/08/04 16:41:01 UTC
[GitHub] tinkerpop pull request #373: TINKERPOP-1151 Made a number of changes to logg...
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/373
TINKERPOP-1151 Made a number of changes to logging dependencies.
https://issues.apache.org/jira/browse/TINKERPOP-1151
Log4j is now generally a test dependency except for gremlin-server and gremlin-console where they need to be shipped as part of the binary distribution. In that case, they are optional scope for those who for some reason depend on those libs.
I tested this a bunch of different ways:
* `mvn clean install` shows the expected log messages
* `mvn clean install -DskipIntegrationTests` shows the expected log messages
* Gremlin Console displays log messages that aren't hidden by the default config and changes to that config allow logs to show in full
* Gremlin Server displays expected log messages
* Looked at the zip distributions and they obviously had the appropriate log4j jars
* Tested builds of both archetype outputs and logging is good within those
Anything else i missed where logging would be an issue? if not then VOTE +1 for me
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1151
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/373.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #373
----
commit 8bf021d28465b3cd88d66baaeacd380161f86086
Author: Stephen Mallette <sp...@genoprime.com>
Date: 2016-08-04T16:26:43Z
Made a number of changes to logging dependencies.
Log4j is now generally a test dependency except for gremlin-server and gremlin-console where they need to be shipped as part of the binary distribution. In that case, they are optional scope for those who for some reason depend on those libs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #373: TINKERPOP-1151 Made a number of changes to logging dep...
Posted by twilmes <gi...@git.apache.org>.
Github user twilmes commented on the issue:
https://github.com/apache/tinkerpop/pull/373
Looking good. VOTE: +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #373: TINKERPOP-1151 Made a number of changes to logging dep...
Posted by PommeVerte <gi...@git.apache.org>.
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/373
Code looks straight forward. VOTE +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #373: TINKERPOP-1151 Made a number of changes to logging dep...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/373
Rebased and force pushed to resolve conflicts on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop pull request #373: TINKERPOP-1151 Made a number of changes to logg...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/373
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---