You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Ross Gardler (JIRA)" <ji...@apache.org> on 2005/08/01 13:58:42 UTC

[jira] Commented: (FOR-590) Enhance the Forrest Seed Project wizard with site configuration options

    [ http://issues.apache.org/jira/browse/FOR-590?page=comments#action_12317317 ] 

Ross Gardler commented on FOR-590:
----------------------------------

I'm confused as to which patch I should be applying (or is it both).

The confusion is caused by *.310705 having lots of changes that are formatting only. This makes it very difficult to identify what the actual code changes are and so I am unable to see if this patch builds on the first or replaces the first.

If you wish to reformat the code (and it is a good idea to do it from time to time) please do not do it with other changes included. That was we can apply the patch with a comment like "whitespace only" which means devs do not waste time trying to work out what the changes are from the commit messages.

For this patch please advise if I am supposed to apply *.29.07.05 followed by *.310705 or if I just apply the later one.

> Enhance the Forrest Seed Project wizard with site configuration options
> -----------------------------------------------------------------------
>
>          Key: FOR-590
>          URL: http://issues.apache.org/jira/browse/FOR-590
>      Project: Forrest
>         Type: New Feature
>   Components: Tool: Eclipse config
>     Versions: 0.8-dev
>     Reporter: Anil Ramnanan
>  Attachments: org.apache.forrest.290705.zip, org.apache.forrest.310705.zip
>
> The new site configuration option needs to allow the user to set more configuration options for the site they are building.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Re: [jira] Commented: (FOR-590) Enhance the Forrest Seed Project wizard with site configuration options

Posted by Ross Gardler <rg...@apache.org>.
Anil Ramnanan wrote:
> Ross Gardler (JIRA) wrote:

...

>> For this patch please advise if I am supposed to apply *.29.07.05 
>> followed by *.310705 or if I just apply the later one.
>>
>>  
>>
> Apply *.310705 only. It replaces the previous one*.29.07.05.

Thanks

> Sorry about 
> the formatting problems, I will keep that in mind.

Don't worry about that, all devs make that mistake every now and again.

Ross

Re: [jira] Commented: (FOR-590) Enhance the Forrest Seed Project wizard with site configuration options

Posted by Anil Ramnanan <li...@peppersauce.org>.
Ross Gardler (JIRA) wrote:

>Ross Gardler commented on FOR-590:
>----------------------------------
>
>I'm confused as to which patch I should be applying (or is it both).
>
>The confusion is caused by *.310705 having lots of changes that are formatting only. This makes it very difficult to identify what the actual code changes are and so I am unable to see if this patch builds on the first or replaces the first.
>
>If you wish to reformat the code (and it is a good idea to do it from time to time) please do not do it with other changes included. That was we can apply the patch with a comment like "whitespace only" which means devs do not waste time trying to work out what the changes are from the commit messages.
>
>For this patch please advise if I am supposed to apply *.29.07.05 followed by *.310705 or if I just apply the later one.
>
>  
>
Apply *.310705 only. It replaces the previous one*.29.07.05. Sorry about 
the formatting problems, I will keep that in mind.

Rgards,
Anil.