You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hop.apache.org by ha...@apache.org on 2020/12/04 08:41:08 UTC
[incubator-hop] branch master updated: Add Github pull request
template
This is an automated email from the ASF dual-hosted git repository.
hansva pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-hop.git
The following commit(s) were added to refs/heads/master by this push:
new 7670318 Add Github pull request template
new 1fcbed3 Merge pull request #432 from fpapon/PR-TEMPLATE
7670318 is described below
commit 767031817ef7776eef8f9d3f1a7bd1f8e908942c
Author: Francois Papon <fr...@openobject.fr>
AuthorDate: Fri Dec 4 09:34:06 2020 +0100
Add Github pull request template
---
.github/pull_request_template.md | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
new file mode 100644
index 0000000..7df4ac4
--- /dev/null
+++ b/.github/pull_request_template.md
@@ -0,0 +1,26 @@
+Following this checklist to help us incorporate your contribution quickly and easily:
+
+ - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/HOP) filed
+ for the change (usually before you start working on it). Trivial changes like typos do not
+ require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
+ - [ ] Each commit in the pull request should have a meaningful subject line and body.
+ - [ ] Format the pull request title like `[HOP-XXX] - Fixes bug in SessionManager`,
+ where you replace `HOP-XXX` with the appropriate JIRA issue. Best practice
+ is to use the JIRA issue title in the pull request title and in the first line of the commit message.
+ - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
+ - [ ] Run `mvn clean install apache-rat:check` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
+ - [ ] If you have a group of commits related to the same change, please squash your commits into one and force push your branch using `git rebase -i`.
+
+Trivial changes like typos do not require a JIRA issue (javadoc, comments...).
+In this case, just format the pull request title like `(DOC) - Add javadoc in SessionManager`.
+
+If this is your first contribution, you have to read the [Contribution Guidelines](https://hop.apache.org/community/contributing/)
+
+If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf)
+if you are unsure please ask on the developers list.
+
+To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
+you have to acknowledge this by using the following check-box.
+
+ - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
+ - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
\ No newline at end of file