You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by je...@apache.org on 2022/01/21 00:07:10 UTC

[airflow] 18/23: fix(standalone): Remove hardcoded Webserver port (#20429)

This is an automated email from the ASF dual-hosted git repository.

jedcunningham pushed a commit to branch v2-2-test
in repository https://gitbox.apache.org/repos/asf/airflow.git

commit b19dfdbc946254cd570b14e032ae9b63042d9339
Author: Jonas Strassel <in...@jonas-strassel.de>
AuthorDate: Tue Dec 21 16:17:00 2021 +0100

    fix(standalone): Remove hardcoded Webserver port (#20429)
    
    Port 8080 is the default port for webserver (https://airflow.apache.org/docs/apache-airflow/stable/cli-and-env-variables-ref.html?highlight=webserver#webserver). By setting it here again explicitly, we forbid users to override it using AIRFLOW__WEBSERVER__WEB_SERVER_PORT. Removing it IMO is not a breaking change, since it will still default to 8080.
    
    (cherry picked from commit 9d36b1fdac16d8db8907d4b792fdbe13a6e80f7e)
---
 airflow/cli/commands/standalone_command.py | 2 +-
 docs/apache-airflow/start/local.rst        | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/airflow/cli/commands/standalone_command.py b/airflow/cli/commands/standalone_command.py
index 41c1684..37d38cb 100644
--- a/airflow/cli/commands/standalone_command.py
+++ b/airflow/cli/commands/standalone_command.py
@@ -72,7 +72,7 @@ class StandaloneCommand:
         self.subcommands["webserver"] = SubCommand(
             self,
             name="webserver",
-            command=["webserver", "--port", "8080"],
+            command=["webserver"],
             env=env,
         )
         self.subcommands["triggerer"] = SubCommand(
diff --git a/docs/apache-airflow/start/local.rst b/docs/apache-airflow/start/local.rst
index b80a933..6441306 100644
--- a/docs/apache-airflow/start/local.rst
+++ b/docs/apache-airflow/start/local.rst
@@ -62,6 +62,7 @@ constraint files to enable reproducible installation, so using ``pip`` and const
 
 Upon running these commands, Airflow will create the ``$AIRFLOW_HOME`` folder
 and create the "airflow.cfg" file with defaults that will get you going fast.
+You can override defaults using environment variables, see :doc:`/configurations-ref`.
 You can inspect the file either in ``$AIRFLOW_HOME/airflow.cfg``, or through the UI in
 the ``Admin->Configuration`` menu. The PID file for the webserver will be stored
 in ``$AIRFLOW_HOME/airflow-webserver.pid`` or in ``/run/airflow/webserver.pid``