You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rob Godfrey (Created) (JIRA)" <ji...@apache.org> on 2011/11/21 13:00:53 UTC
[jira] [Created] (QPID-3635) AMQQConnectionTest incorrect assumes
an order in which the tests are run
AMQQConnectionTest incorrect assumes an order in which the tests are run
------------------------------------------------------------------------
Key: QPID-3635
URL: https://issues.apache.org/jira/browse/QPID-3635
Project: Qpid
Issue Type: Bug
Components: Java Tests
Reporter: Rob Godfrey
Priority: Minor
The AMQConnection test class makes assumptions about the order in which tests are run and is generally just horribly ill-conceived.
For example the test testTopicSessionCreateBrowser() depends upon the initialisation of the member variable _topicSession which is initialised in the test testCreateTopicSession(), and is only still valid since though the test creates new connections in every setUp, it does not tear them down at the end of each test.
Note also that if the creation of _topicSession and _queueSession are moved to setUp then the test testGetChannelID() will fail as it depends on no prior sessions existing and also on a defined policy of assigning channel numbers to sessions (really this test makes no sense at all).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3635) AMQQConnectionTest incorrect assumes
an order in which the tests are run
Posted by "Keith Wall (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-3635:
-----------------------------
Status: Ready To Review (was: In Progress)
> AMQQConnectionTest incorrect assumes an order in which the tests are run
> ------------------------------------------------------------------------
>
> Key: QPID-3635
> URL: https://issues.apache.org/jira/browse/QPID-3635
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Rob Godfrey
> Assignee: Keith Wall
> Priority: Minor
>
> The AMQConnection test class makes assumptions about the order in which tests are run and is generally just horribly ill-conceived.
> For example the test testTopicSessionCreateBrowser() depends upon the initialisation of the member variable _topicSession which is initialised in the test testCreateTopicSession(), and is only still valid since though the test creates new connections in every setUp, it does not tear them down at the end of each test.
> Note also that if the creation of _topicSession and _queueSession are moved to setUp then the test testGetChannelID() will fail as it depends on no prior sessions existing and also on a defined policy of assigning channel numbers to sessions (really this test makes no sense at all).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3635) AMQQConnectionTest incorrect assumes
an order in which the tests are run
Posted by "Keith Wall (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-3635:
--------------------------------
Assignee: Robbie Gemmell (was: Keith Wall)
> AMQQConnectionTest incorrect assumes an order in which the tests are run
> ------------------------------------------------------------------------
>
> Key: QPID-3635
> URL: https://issues.apache.org/jira/browse/QPID-3635
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Rob Godfrey
> Assignee: Robbie Gemmell
> Priority: Minor
>
> The AMQConnection test class makes assumptions about the order in which tests are run and is generally just horribly ill-conceived.
> For example the test testTopicSessionCreateBrowser() depends upon the initialisation of the member variable _topicSession which is initialised in the test testCreateTopicSession(), and is only still valid since though the test creates new connections in every setUp, it does not tear them down at the end of each test.
> Note also that if the creation of _topicSession and _queueSession are moved to setUp then the test testGetChannelID() will fail as it depends on no prior sessions existing and also on a defined policy of assigning channel numbers to sessions (really this test makes no sense at all).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3635) AMQQConnectionTest incorrect assumes
an order in which the tests are run
Posted by "Keith Wall (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall updated QPID-3635:
-----------------------------
Fix Version/s: 0.15
> AMQQConnectionTest incorrect assumes an order in which the tests are run
> ------------------------------------------------------------------------
>
> Key: QPID-3635
> URL: https://issues.apache.org/jira/browse/QPID-3635
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Rob Godfrey
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.15
>
>
> The AMQConnection test class makes assumptions about the order in which tests are run and is generally just horribly ill-conceived.
> For example the test testTopicSessionCreateBrowser() depends upon the initialisation of the member variable _topicSession which is initialised in the test testCreateTopicSession(), and is only still valid since though the test creates new connections in every setUp, it does not tear them down at the end of each test.
> Note also that if the creation of _topicSession and _queueSession are moved to setUp then the test testGetChannelID() will fail as it depends on no prior sessions existing and also on a defined policy of assigning channel numbers to sessions (really this test makes no sense at all).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3635) AMQQConnectionTest incorrect assumes
an order in which the tests are run
Posted by "Robbie Gemmell (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-3635.
----------------------------------
Resolution: Fixed
Changes look good to me.
> AMQQConnectionTest incorrect assumes an order in which the tests are run
> ------------------------------------------------------------------------
>
> Key: QPID-3635
> URL: https://issues.apache.org/jira/browse/QPID-3635
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Rob Godfrey
> Assignee: Robbie Gemmell
> Priority: Minor
> Fix For: 0.15
>
>
> The AMQConnection test class makes assumptions about the order in which tests are run and is generally just horribly ill-conceived.
> For example the test testTopicSessionCreateBrowser() depends upon the initialisation of the member variable _topicSession which is initialised in the test testCreateTopicSession(), and is only still valid since though the test creates new connections in every setUp, it does not tear them down at the end of each test.
> Note also that if the creation of _topicSession and _queueSession are moved to setUp then the test testGetChannelID() will fail as it depends on no prior sessions existing and also on a defined policy of assigning channel numbers to sessions (really this test makes no sense at all).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3635) AMQQConnectionTest incorrect assumes
an order in which the tests are run
Posted by "Keith Wall (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184953#comment-13184953 ]
Keith Wall commented on QPID-3635:
----------------------------------
Patch applied to generally make these test case more sane:
1) testPrefetchSystemProperty to PrefetchBehaviourTest for better division of responsibilities between tests.
2) Split AMQConnectionTest into QueueSessionFactoryTest and TopicSessionFactoryTest.
3) Removed AMQSSLConnectionTest as there is nothing transport specific and therefore added nothing not already tested by SSLTest.
> AMQQConnectionTest incorrect assumes an order in which the tests are run
> ------------------------------------------------------------------------
>
> Key: QPID-3635
> URL: https://issues.apache.org/jira/browse/QPID-3635
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Rob Godfrey
> Assignee: Keith Wall
> Priority: Minor
>
> The AMQConnection test class makes assumptions about the order in which tests are run and is generally just horribly ill-conceived.
> For example the test testTopicSessionCreateBrowser() depends upon the initialisation of the member variable _topicSession which is initialised in the test testCreateTopicSession(), and is only still valid since though the test creates new connections in every setUp, it does not tear them down at the end of each test.
> Note also that if the creation of _topicSession and _queueSession are moved to setUp then the test testGetChannelID() will fail as it depends on no prior sessions existing and also on a defined policy of assigning channel numbers to sessions (really this test makes no sense at all).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3635) AMQQConnectionTest incorrect assumes
an order in which the tests are run
Posted by "Keith Wall (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-3635:
--------------------------------
Assignee: Keith Wall
> AMQQConnectionTest incorrect assumes an order in which the tests are run
> ------------------------------------------------------------------------
>
> Key: QPID-3635
> URL: https://issues.apache.org/jira/browse/QPID-3635
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Rob Godfrey
> Assignee: Keith Wall
> Priority: Minor
>
> The AMQConnection test class makes assumptions about the order in which tests are run and is generally just horribly ill-conceived.
> For example the test testTopicSessionCreateBrowser() depends upon the initialisation of the member variable _topicSession which is initialised in the test testCreateTopicSession(), and is only still valid since though the test creates new connections in every setUp, it does not tear them down at the end of each test.
> Note also that if the creation of _topicSession and _queueSession are moved to setUp then the test testGetChannelID() will fail as it depends on no prior sessions existing and also on a defined policy of assigning channel numbers to sessions (really this test makes no sense at all).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3635) AMQQConnectionTest incorrect assumes
an order in which the tests are run
Posted by "Keith Wall (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-3635:
--------------------------------
Assignee: Keith Wall (was: Robbie Gemmell)
> AMQQConnectionTest incorrect assumes an order in which the tests are run
> ------------------------------------------------------------------------
>
> Key: QPID-3635
> URL: https://issues.apache.org/jira/browse/QPID-3635
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Rob Godfrey
> Assignee: Keith Wall
> Priority: Minor
>
> The AMQConnection test class makes assumptions about the order in which tests are run and is generally just horribly ill-conceived.
> For example the test testTopicSessionCreateBrowser() depends upon the initialisation of the member variable _topicSession which is initialised in the test testCreateTopicSession(), and is only still valid since though the test creates new connections in every setUp, it does not tear them down at the end of each test.
> Note also that if the creation of _topicSession and _queueSession are moved to setUp then the test testGetChannelID() will fail as it depends on no prior sessions existing and also on a defined policy of assigning channel numbers to sessions (really this test makes no sense at all).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3635) AMQQConnectionTest incorrect assumes
an order in which the tests are run
Posted by "Keith Wall (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-3635:
--------------------------------
Assignee: Robbie Gemmell (was: Keith Wall)
Rob's patch for QPID-3714 addressed the immediate problem of this test. This patch hopefully addresses the wider ill-conceived nature of the test.
> AMQQConnectionTest incorrect assumes an order in which the tests are run
> ------------------------------------------------------------------------
>
> Key: QPID-3635
> URL: https://issues.apache.org/jira/browse/QPID-3635
> Project: Qpid
> Issue Type: Bug
> Components: Java Tests
> Reporter: Rob Godfrey
> Assignee: Robbie Gemmell
> Priority: Minor
>
> The AMQConnection test class makes assumptions about the order in which tests are run and is generally just horribly ill-conceived.
> For example the test testTopicSessionCreateBrowser() depends upon the initialisation of the member variable _topicSession which is initialised in the test testCreateTopicSession(), and is only still valid since though the test creates new connections in every setUp, it does not tear them down at the end of each test.
> Note also that if the creation of _topicSession and _queueSession are moved to setUp then the test testGetChannelID() will fail as it depends on no prior sessions existing and also on a defined policy of assigning channel numbers to sessions (really this test makes no sense at all).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org