[GitHub] [geode] DonalEvans commented on a change in pull request #5832: GEODE-8778: Change conserve-sockets default value to false

[GitBox <gi...@apache.org>]

DonalEvans commented on a change in pull request #5832:
URL: https://github.com/apache/geode/pull/5832#discussion_r539745407



##########
File path: geode-core/src/distributedTest/java/org/apache/geode/internal/tcp/CloseConnectionTest.java
##########
@@ -40,14 +41,15 @@
 import org.apache.geode.test.dunit.rules.DistributedRule;
 
 public class CloseConnectionTest implements Serializable {
+  private static final long serialVersionUID = 3692493564204797623L;
   private VM vm0;
   private VM vm1;
 
   @Rule
   public DistributedRule distributedRule = new DistributedRule();
 
   @Rule
-  public CacheRule cacheRule = new CacheRule();
+  public CacheRule cacheRule = new CacheRule.Builder().addConfig(CONSERVE_SOCKETS, "true").build();

Review comment:
       The test class only contains one test case, which is `sharedSenderShouldRecoverFromClosedSocket()`. It's not immediately obvious that this implies `conserve-sockets=true` so adding some javadocs would be a good idea, I think.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org