You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2011/07/09 06:22:44 UTC
introducing wicket:for attribute
just implemented the wicket:for attribute. check out the javadoc here:
http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
1.4.x only for now, still needs to be forward-ported to trunk.
feedback?
-igor
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Clint Checketts <ch...@gmail.com>.
Great! Thanks for doing this!
On Fri, Jul 8, 2011 at 11:22 PM, Igor Vaynberg <ig...@gmail.com>wrote:
> just implemented the wicket:for attribute. check out the javadoc here:
>
>
> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
>
> 1.4.x only for now, still needs to be forward-ported to trunk.
>
> feedback?
>
> -igor
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
Re: introducing wicket:for attribute
Posted by Christian Huber <hu...@butterbrot.org>.
Looks very nifty indeed. Thank you for this addition.
Btw, minor mistake in the javadoc, at line 43 the term 'a path' is
doubled ;-)
Am 09.07.2011 07:46, schrieb Steve Swinsburg:
> This is excellent Igor, our accessibility people will be very thankful! Please leave it in 1.4.x!
>
> cheers,
> Steve
>
>
>
> On 09/07/2011, at 2:22 PM, Igor Vaynberg wrote:
>
>> just implemented the wicket:for attribute. check out the javadoc here:
>>
>> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
>>
>> 1.4.x only for now, still needs to be forward-ported to trunk.
>>
>> feedback?
>>
>> -igor
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Steve Swinsburg <st...@gmail.com>.
This is excellent Igor, our accessibility people will be very thankful! Please leave it in 1.4.x!
cheers,
Steve
On 09/07/2011, at 2:22 PM, Igor Vaynberg wrote:
> just implemented the wicket:for attribute. check out the javadoc here:
>
> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
>
> 1.4.x only for now, still needs to be forward-ported to trunk.
>
> feedback?
>
> -igor
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Igor Vaynberg <ig...@gmail.com>.
On Sat, Jul 9, 2011 at 12:25 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> ported to trunk
>
> -igor
>
> On Fri, Jul 8, 2011 at 10:42 PM, robert.mcguinness
> <ro...@gmail.com> wrote:
>> this is going to cleanup a lot of code. much obliged. please let us know
>> when in 1.5.x branch.
>>
>> --
>> View this message in context: http://apache-wicket.1842946.n4.nabble.com/introducing-wicket-for-attribute-tp3655611p3655660.html
>> Sent from the Users forum mailing list archive at Nabble.com.
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Igor Vaynberg <ig...@gmail.com>.
ported to trunk
-igor
On Fri, Jul 8, 2011 at 10:42 PM, robert.mcguinness
<ro...@gmail.com> wrote:
> this is going to cleanup a lot of code. much obliged. please let us know
> when in 1.5.x branch.
>
> --
> View this message in context: http://apache-wicket.1842946.n4.nabble.com/introducing-wicket-for-attribute-tp3655611p3655660.html
> Sent from the Users forum mailing list archive at Nabble.com.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by "robert.mcguinness" <ro...@gmail.com>.
this is going to cleanup a lot of code. much obliged. please let us know
when in 1.5.x branch.
--
View this message in context: http://apache-wicket.1842946.n4.nabble.com/introducing-wicket-for-attribute-tp3655611p3655660.html
Sent from the Users forum mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Igor Vaynberg <ig...@gmail.com>.
sweet, i will give that a go in the future. thanks.
-igor
On Thu, Jul 14, 2011 at 3:05 AM, Erik van Oosten <e....@grons.nl> wrote:
> Its not @literal that removes the linebreaks. If you combine it with <pre>
> it works. (No need to add <code> as well.)
>
> *<pre>{@literal
> * <label wicket:for="name">
> * <span class="label-text">Name</span>:
> * </label>
> * <input wicket:id="name" type="text"/>
> * }</pre>
> *
>
> Regards,
> Erik.
>
>
> Op 13-07-11 17:55, Igor Vaynberg schreef:
>>
>> sweet, too bad @literal does not preserve linebreaks. what we really
>> need is a CDATA like javadoc tag.
>>
>> -igor
>>
>> On Wed, Jul 13, 2011 at 4:12 AM, Erik van Oosten<e....@grons.nl>
>> wrote:
>>>
>>> Amazing stuff!
>>>
>>> You can write straight html in javadoc with the {@literal} syntax. E.g.:
>>>
>>> *<p>
>>> * Given markup like this:
>>> *
>>> *<code>{@literal
>>> *<label wicket:for="name"><span
>>> class="label-text">Name</span>:</label><input wicket:id="name"
>>> type="text"/>
>>> * }</code>
>>> *
>>> * If the {@code name} component has its label set to 'First Name' the
>>> resulting output will be:
>>> *<code>{@literal
>>> *<label for="name5"><span class="label-text">First
>>> Name</span>:</label><input name="name" type="text" id="name5"/>
>>> * }</code>
>>>
>>> Regards,
>>> Erik.
>>>
>>>
>>> Op 13-07-11 01:50, Igor Vaynberg wrote:
>>>>
>>>> based on some feedback i changed the class name of the inner span from
>>>> "text" to "label-text" to reduce chance of css collisions
>>>>
>>>> -igor
>>>>
>>>> On Fri, Jul 8, 2011 at 9:22 PM, Igor Vaynberg<ig...@gmail.com>
>>>> wrote:
>>>>>
>>>>> just implemented the wicket:for attribute. check out the javadoc here:
>>>>>
>>>>>
>>>>>
>>>>> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
>>>>>
>>>>> 1.4.x only for now, still needs to be forward-ported to trunk.
>>>>>
>>>>> feedback?
>>>>>
>>>>> -igor
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Erik van Oosten <e....@grons.nl>.
Its not @literal that removes the linebreaks. If you combine it with
<pre> it works. (No need to add <code> as well.)
*<pre>{@literal
* <label wicket:for="name">
* <span class="label-text">Name</span>:
* </label>
* <input wicket:id="name" type="text"/>
* }</pre>
*
Regards,
Erik.
Op 13-07-11 17:55, Igor Vaynberg schreef:
> sweet, too bad @literal does not preserve linebreaks. what we really
> need is a CDATA like javadoc tag.
>
> -igor
>
> On Wed, Jul 13, 2011 at 4:12 AM, Erik van Oosten<e....@grons.nl> wrote:
>> Amazing stuff!
>>
>> You can write straight html in javadoc with the {@literal} syntax. E.g.:
>>
>> *<p>
>> * Given markup like this:
>> *
>> *<code>{@literal
>> *<label wicket:for="name"><span
>> class="label-text">Name</span>:</label><input wicket:id="name" type="text"/>
>> * }</code>
>> *
>> * If the {@code name} component has its label set to 'First Name' the
>> resulting output will be:
>> *<code>{@literal
>> *<label for="name5"><span class="label-text">First
>> Name</span>:</label><input name="name" type="text" id="name5"/>
>> * }</code>
>>
>> Regards,
>> Erik.
>>
>>
>> Op 13-07-11 01:50, Igor Vaynberg wrote:
>>> based on some feedback i changed the class name of the inner span from
>>> "text" to "label-text" to reduce chance of css collisions
>>>
>>> -igor
>>>
>>> On Fri, Jul 8, 2011 at 9:22 PM, Igor Vaynberg<ig...@gmail.com>
>>> wrote:
>>>> just implemented the wicket:for attribute. check out the javadoc here:
>>>>
>>>>
>>>> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
>>>>
>>>> 1.4.x only for now, still needs to be forward-ported to trunk.
>>>>
>>>> feedback?
>>>>
>>>> -igor
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Igor Vaynberg <ig...@gmail.com>.
right, we use <pre> and <code> but the escaping of html sux
-igor
On Wed, Jul 13, 2011 at 12:36 PM, Zilvinas Vilutis <ci...@gmail.com> wrote:
> You can use <pre> in javadocs, and still you'd need to escape html
> entities ( ">" to ">", & etc )
>
> Žilvinas Vilutis
>
> Mobile: (+1) 623 330 6048
> E-mail: cikasfm@gmail.com
>
>
>
> On Wed, Jul 13, 2011 at 8:55 AM, Igor Vaynberg <ig...@gmail.com> wrote:
>> sweet, too bad @literal does not preserve linebreaks. what we really
>> need is a CDATA like javadoc tag.
>>
>> -igor
>>
>> On Wed, Jul 13, 2011 at 4:12 AM, Erik van Oosten <e....@grons.nl> wrote:
>>> Amazing stuff!
>>>
>>> You can write straight html in javadoc with the {@literal} syntax. E.g.:
>>>
>>> *<p>
>>> * Given markup like this:
>>> *
>>> *<code>{@literal
>>> *<label wicket:for="name"><span
>>> class="label-text">Name</span>:</label><input wicket:id="name" type="text"/>
>>> * }</code>
>>> *
>>> * If the {@code name} component has its label set to 'First Name' the
>>> resulting output will be:
>>> *<code>{@literal
>>> *<label for="name5"><span class="label-text">First
>>> Name</span>:</label><input name="name" type="text" id="name5"/>
>>> * }</code>
>>>
>>> Regards,
>>> Erik.
>>>
>>>
>>> Op 13-07-11 01:50, Igor Vaynberg wrote:
>>>>
>>>> based on some feedback i changed the class name of the inner span from
>>>> "text" to "label-text" to reduce chance of css collisions
>>>>
>>>> -igor
>>>>
>>>> On Fri, Jul 8, 2011 at 9:22 PM, Igor Vaynberg<ig...@gmail.com>
>>>> wrote:
>>>>>
>>>>> just implemented the wicket:for attribute. check out the javadoc here:
>>>>>
>>>>>
>>>>> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
>>>>>
>>>>> 1.4.x only for now, still needs to be forward-ported to trunk.
>>>>>
>>>>> feedback?
>>>>>
>>>>> -igor
>>>>
>>>
>>> --
>>> Erik van Oosten
>>> http://www.day-to-day-stuff.blogspot.com/
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Zilvinas Vilutis <ci...@gmail.com>.
You can use <pre> in javadocs, and still you'd need to escape html
entities ( ">" to ">", & etc )
Žilvinas Vilutis
Mobile: (+1) 623 330 6048
E-mail: cikasfm@gmail.com
On Wed, Jul 13, 2011 at 8:55 AM, Igor Vaynberg <ig...@gmail.com> wrote:
> sweet, too bad @literal does not preserve linebreaks. what we really
> need is a CDATA like javadoc tag.
>
> -igor
>
> On Wed, Jul 13, 2011 at 4:12 AM, Erik van Oosten <e....@grons.nl> wrote:
>> Amazing stuff!
>>
>> You can write straight html in javadoc with the {@literal} syntax. E.g.:
>>
>> *<p>
>> * Given markup like this:
>> *
>> *<code>{@literal
>> *<label wicket:for="name"><span
>> class="label-text">Name</span>:</label><input wicket:id="name" type="text"/>
>> * }</code>
>> *
>> * If the {@code name} component has its label set to 'First Name' the
>> resulting output will be:
>> *<code>{@literal
>> *<label for="name5"><span class="label-text">First
>> Name</span>:</label><input name="name" type="text" id="name5"/>
>> * }</code>
>>
>> Regards,
>> Erik.
>>
>>
>> Op 13-07-11 01:50, Igor Vaynberg wrote:
>>>
>>> based on some feedback i changed the class name of the inner span from
>>> "text" to "label-text" to reduce chance of css collisions
>>>
>>> -igor
>>>
>>> On Fri, Jul 8, 2011 at 9:22 PM, Igor Vaynberg<ig...@gmail.com>
>>> wrote:
>>>>
>>>> just implemented the wicket:for attribute. check out the javadoc here:
>>>>
>>>>
>>>> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
>>>>
>>>> 1.4.x only for now, still needs to be forward-ported to trunk.
>>>>
>>>> feedback?
>>>>
>>>> -igor
>>>
>>
>> --
>> Erik van Oosten
>> http://www.day-to-day-stuff.blogspot.com/
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Igor Vaynberg <ig...@gmail.com>.
sweet, too bad @literal does not preserve linebreaks. what we really
need is a CDATA like javadoc tag.
-igor
On Wed, Jul 13, 2011 at 4:12 AM, Erik van Oosten <e....@grons.nl> wrote:
> Amazing stuff!
>
> You can write straight html in javadoc with the {@literal} syntax. E.g.:
>
> *<p>
> * Given markup like this:
> *
> *<code>{@literal
> *<label wicket:for="name"><span
> class="label-text">Name</span>:</label><input wicket:id="name" type="text"/>
> * }</code>
> *
> * If the {@code name} component has its label set to 'First Name' the
> resulting output will be:
> *<code>{@literal
> *<label for="name5"><span class="label-text">First
> Name</span>:</label><input name="name" type="text" id="name5"/>
> * }</code>
>
> Regards,
> Erik.
>
>
> Op 13-07-11 01:50, Igor Vaynberg wrote:
>>
>> based on some feedback i changed the class name of the inner span from
>> "text" to "label-text" to reduce chance of css collisions
>>
>> -igor
>>
>> On Fri, Jul 8, 2011 at 9:22 PM, Igor Vaynberg<ig...@gmail.com>
>> wrote:
>>>
>>> just implemented the wicket:for attribute. check out the javadoc here:
>>>
>>>
>>> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
>>>
>>> 1.4.x only for now, still needs to be forward-ported to trunk.
>>>
>>> feedback?
>>>
>>> -igor
>>
>
> --
> Erik van Oosten
> http://www.day-to-day-stuff.blogspot.com/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Erik van Oosten <e....@grons.nl>.
Amazing stuff!
You can write straight html in javadoc with the {@literal} syntax. E.g.:
*<p>
* Given markup like this:
*
*<code>{@literal
*<label wicket:for="name"><span class="label-text">Name</span>:</label><input wicket:id="name" type="text"/>
* }</code>
*
* If the {@code name} component has its label set to 'First Name' the resulting output will be:
*<code>{@literal
*<label for="name5"><span class="label-text">First Name</span>:</label><input name="name" type="text" id="name5"/>
* }</code>
Regards,
Erik.
Op 13-07-11 01:50, Igor Vaynberg wrote:
> based on some feedback i changed the class name of the inner span from
> "text" to "label-text" to reduce chance of css collisions
>
> -igor
>
> On Fri, Jul 8, 2011 at 9:22 PM, Igor Vaynberg<ig...@gmail.com> wrote:
>> just implemented the wicket:for attribute. check out the javadoc here:
>>
>> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
>>
>> 1.4.x only for now, still needs to be forward-ported to trunk.
>>
>> feedback?
>>
>> -igor
>
--
Erik van Oosten
http://www.day-to-day-stuff.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org
Re: introducing wicket:for attribute
Posted by Igor Vaynberg <ig...@gmail.com>.
based on some feedback i changed the class name of the inner span from
"text" to "label-text" to reduce chance of css collisions
-igor
On Fri, Jul 8, 2011 at 9:22 PM, Igor Vaynberg <ig...@gmail.com> wrote:
> just implemented the wicket:for attribute. check out the javadoc here:
>
> http://svn.apache.org/viewvc/wicket/branches/wicket-1.4.x/wicket/src/main/java/org/apache/wicket/markup/html/form/AutoLabelResolver.java?view=markup&pathrev=1144589
>
> 1.4.x only for now, still needs to be forward-ported to trunk.
>
> feedback?
>
> -igor
>
---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org