You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org> on 2020/04/22 10:44:51 UTC
[kudu-CR] [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
Volodymyr Verovkin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15782
Change subject: [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
......................................................................
[c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
gcc-9.2.1 produced error:
kudu/thirdparty/src/breakpad-9eac2058b70615519b2c4d8c6bdbfca1bd079e39/
src/third_party/lss/linux_syscall_support.h:
In member function ‘bool
google_breakpad::ExceptionHandler::GenerateDump(
google_breakpad::ExceptionHandler::CrashContext*)’:
kudu/thirdparty/src/breakpad-9eac2058b70615519b2c4d8c6bdbfca1bd079e39/
src/third_party/lss/linux_syscall_support.h:2379:75:
error: listing the stack pointer register ‘rsp’ in a clobber list is
deprecated [-Werror=deprecated]
: "rsp", "memory", "r8", "r10", "r11", "rcx");
Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a
---
M thirdparty/build-definitions.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/15782/1
--
To view, visit http://gerrit.cloudera.org:8080/15782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a
Gerrit-Change-Number: 15782
Gerrit-PatchSet: 1
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
[kudu-CR] [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
Posted by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15782
to look at the new patch set (#2).
Change subject: [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
......................................................................
[c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
gcc-9.2.1 produced error:
kudu/thirdparty/src/breakpad-9eac2058b70615519b2c4d8c6bdbfca1bd079e39/
src/third_party/lss/linux_syscall_support.h:
In member function ‘bool
google_breakpad::ExceptionHandler::GenerateDump(
google_breakpad::ExceptionHandler::CrashContext*)’:
kudu/thirdparty/src/breakpad-9eac2058b70615519b2c4d8c6bdbfca1bd079e39/
src/third_party/lss/linux_syscall_support.h:2379:75:
error: listing the stack pointer register ‘rsp’ in a clobber list is
deprecated [-Werror=deprecated]
: "rsp", "memory", "r8", "r10", "r11", "rcx");
It's fixed by patch from Google Chromium team.
Reference patch:
https://chromium.googlesource.com/linux-syscall-support/+/8048ece6c16c91acfe0d36d1d3cc0890ab6e945c%5E%21/
Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/breakpad-syscall-rsp-clobber-fix.patch
2 files changed, 25 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/15782/2
--
To view, visit http://gerrit.cloudera.org:8080/15782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a
Gerrit-Change-Number: 15782
Gerrit-PatchSet: 2
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15782 )
Change subject: [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a
Gerrit-Change-Number: 15782
Gerrit-PatchSet: 2
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 27 Apr 2020 23:07:52 +0000
Gerrit-HasComments: No
[kudu-CR] [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15782 )
Change subject: [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a
Gerrit-Change-Number: 15782
Gerrit-PatchSet: 2
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 27 Apr 2020 22:22:38 +0000
Gerrit-HasComments: No
[kudu-CR] [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15782 )
Change subject: [c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
......................................................................
[c++17] Fixed compilation error of thirdparty package "breakpad" in gcc9
gcc-9.2.1 produced error:
kudu/thirdparty/src/breakpad-9eac2058b70615519b2c4d8c6bdbfca1bd079e39/
src/third_party/lss/linux_syscall_support.h:
In member function ‘bool
google_breakpad::ExceptionHandler::GenerateDump(
google_breakpad::ExceptionHandler::CrashContext*)’:
kudu/thirdparty/src/breakpad-9eac2058b70615519b2c4d8c6bdbfca1bd079e39/
src/third_party/lss/linux_syscall_support.h:2379:75:
error: listing the stack pointer register ‘rsp’ in a clobber list is
deprecated [-Werror=deprecated]
: "rsp", "memory", "r8", "r10", "r11", "rcx");
It's fixed by patch from Google Chromium team.
Reference patch:
https://chromium.googlesource.com/linux-syscall-support/+/8048ece6c16c91acfe0d36d1d3cc0890ab6e945c%5E%21/
Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a
Reviewed-on: http://gerrit.cloudera.org:8080/15782
Tested-by: Kudu Jenkins
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/breakpad-syscall-rsp-clobber-fix.patch
2 files changed, 25 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Bankim Bhavsar: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/15782
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I75706392c5347a1b13f39b04d8c21b6ea528797a
Gerrit-Change-Number: 15782
Gerrit-PatchSet: 3
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)