You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Michele Palmia (Jira)" <ji...@apache.org> on 2020/03/05 12:07:00 UTC

[jira] [Commented] (LUCENE-8103) QueryValueSource should use TwoPhaseIterator

    [ https://issues.apache.org/jira/browse/LUCENE-8103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052064#comment-17052064 ] 

Michele Palmia commented on LUCENE-8103:
----------------------------------------

Why would a Scorer offer a fast TwoPhaseIterator but not serve it (repackaged as DocIdSetIterator) when asked for a simple old-school iterator()? In my naivety, I would expect that in case a fast TPI is implemented, it would always be served when clients call iterator() too.

In case that's not the case, and an explicit repackage is useful, here's my patch.
[^LUCENE-8103.patch]

> QueryValueSource should use TwoPhaseIterator
> --------------------------------------------
>
>                 Key: LUCENE-8103
>                 URL: https://issues.apache.org/jira/browse/LUCENE-8103
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/other
>            Reporter: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-8103.patch
>
>
> QueryValueSource (in "queries" module) is a ValueSource representation of a Query; the score is the value.  It ought to try to use a TwoPhaseIterator from the query if it can be offered. This will prevent possibly expensive advancing beyond documents that we aren't interested in.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org