You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/11/28 14:15:20 UTC
[GitHub] [arrow-datafusion] alamb opened a new issue #1377: Add tests for TPCH explain plans to avoid regressions
alamb opened a new issue #1377:
URL: https://github.com/apache/arrow-datafusion/issues/1377
**Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
We have had performance regressions in the TPCH plans due to plan changes (e.g. https://github.com/apache/arrow-datafusion/issues/1367)
In order to avoid this situation in the future, we would like to have the explain plans committed as tests (so we can evaluate any changes to those plans as part of normal PR review)
**Describe the solution you'd like**
Add tests that `EXPLAIN ...` the TPCQ queries, following the model of the test added by @viirya in https://github.com/apache/arrow-datafusion/pull/1368
Ideally this would be in the `tpch` crate, as suggested in @Dandandan https://github.com/apache/arrow-datafusion/pull/1368/files#r757892477
**Describe alternatives you've considered**
A clear and concise description of any alternative solutions or features you've considered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] viirya commented on issue #1377: Add tests for TPCH explain plans to avoid regressions
Posted by GitBox <gi...@apache.org>.
viirya commented on issue #1377:
URL: https://github.com/apache/arrow-datafusion/issues/1377#issuecomment-981121332
BTW, does the tpch crate mean the benchmarks? Otherwise I don't find a tpch crate here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on issue #1377: Add tests for TPCH explain plans to avoid regressions
Posted by GitBox <gi...@apache.org>.
alamb commented on issue #1377:
URL: https://github.com/apache/arrow-datafusion/issues/1377#issuecomment-981549025
> BTW, does the tpch crate mean the benchmarks? Otherwise I don't find a tpch crate here.
Yes, I think that is right.
So perhaps we could add some sort of test in https://github.com/apache/arrow-datafusion/blob/master/benchmarks/src such as `benchmarks/tests/plans.rs` that used the queries in https://github.com/apache/arrow-datafusion/tree/master/benchmarks/queries.
We could probably adapt lots of https://github.com/apache/arrow-datafusion/blob/master/benchmarks/src/bin/tpch.rs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org