You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/18 00:54:03 UTC
[GitHub] [helix] NealSun96 opened a new issue #901: Fix issues uncovered by
the 2nd round of MSDS manual testing
NealSun96 opened a new issue #901: Fix issues uncovered by the 2nd round of MSDS manual testing
URL: https://github.com/apache/helix/issues/901
3 issues were uncovered by the second round of MetadataStoreDirectory Service manual testing:
1. `SetRoutingData` does not respect the return value of the underlying function.
2. The port of each instance is not considered when forwarding requests, therefore failing all the forwarded requests.
3. "/admin/v2" is not added when forwarding requests, therefore (would be) failing the forwarded requests.
Fixes: return 500 when false; add mechanism to read ports from system configs (just like hostname); add mechanism to read url prefixes from system configs (just like hostname).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] narendly closed issue #901: Fix issues uncovered by the 2nd
round of MSDS manual testing
Posted by GitBox <gi...@apache.org>.
narendly closed issue #901: Fix issues uncovered by the 2nd round of MSDS manual testing
URL: https://github.com/apache/helix/issues/901
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org