You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/09/08 03:22:48 UTC
[GitHub] [spark] panbingkun opened a new pull request, #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
panbingkun opened a new pull request, #42852:
URL: https://github.com/apache/spark/pull/42852
### What changes were proposed in this pull request?
The pr aims to fix potentially wrong underline length.
### Why are the changes needed?
Fix potentially wrong underline length.
<img width="951" alt="image" src="https://github.com/apache/spark/assets/15246973/8f5e8648-7670-4dce-860b-bd12c52e73f3">
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually test.
```
cd python/docs
make clean html
```
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yaooqinn commented on pull request #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #42852:
URL: https://github.com/apache/spark/pull/42852#issuecomment-1711035136
Although it's a good style to align the title and the underline length, but it is also acceptable for reStruturedText if not matched. It's too nit for a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun closed pull request #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun closed pull request #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
URL: https://github.com/apache/spark/pull/42852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #42852:
URL: https://github.com/apache/spark/pull/42852#issuecomment-1711021740
cc @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42852:
URL: https://github.com/apache/spark/pull/42852#discussion_r1319381075
##########
python/pyspark/sql/functions.py:
##########
@@ -4626,7 +4626,7 @@ def approx_count_distinct(col: "ColumnOrName", rsd: Optional[float] = None) -> C
A new Column object representing the approximate unique count.
See Also
- ----------
Review Comment:
Yeah let's just fold it to that PR together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #42852:
URL: https://github.com/apache/spark/pull/42852#discussion_r1319372371
##########
python/pyspark/sql/functions.py:
##########
@@ -4626,7 +4626,7 @@ def approx_count_distinct(col: "ColumnOrName", rsd: Optional[float] = None) -> C
A new Column object representing the approximate unique count.
See Also
- ----------
Review Comment:
Yes, it's just the only one in the whole, because I didn't notice it last week when I was working on doc related work. It should have appeared in the past week.If this change is too nit for a separate PR, I can also merge it into another PR (eg: https://github.com/apache/spark/pull/42834) to cover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #42852:
URL: https://github.com/apache/spark/pull/42852#discussion_r1319377522
##########
python/pyspark/sql/functions.py:
##########
@@ -4626,7 +4626,7 @@ def approx_count_distinct(col: "ColumnOrName", rsd: Optional[float] = None) -> C
A new Column object representing the approximate unique count.
See Also
- ----------
Review Comment:
<img width="699" alt="image" src="https://github.com/apache/spark/assets/15246973/7939e13d-2bde-4dd7-a4bf-4a0325035f80">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #42852:
URL: https://github.com/apache/spark/pull/42852#discussion_r1319372371
##########
python/pyspark/sql/functions.py:
##########
@@ -4626,7 +4626,7 @@ def approx_count_distinct(col: "ColumnOrName", rsd: Optional[float] = None) -> C
A new Column object representing the approximate unique count.
See Also
- ----------
Review Comment:
Yes, it's just the only one in the whole, because I didn't notice it last week when I was working on doc related work. It should have appeared in the past week.If I think this change is too nit, I can also merge it into another PR to cover it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #42852:
URL: https://github.com/apache/spark/pull/42852#discussion_r1319369395
##########
python/pyspark/sql/functions.py:
##########
@@ -4626,7 +4626,7 @@ def approx_count_distinct(col: "ColumnOrName", rsd: Optional[float] = None) -> C
A new Column object representing the approximate unique count.
See Also
- ----------
Review Comment:
Can we fix them all? or is this the last one left?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on a diff in pull request #42852: [MINOR][PYTHON][DOCS] Fix potentially wrong underline length
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on code in PR #42852:
URL: https://github.com/apache/spark/pull/42852#discussion_r1319391437
##########
python/pyspark/sql/functions.py:
##########
@@ -4626,7 +4626,7 @@ def approx_count_distinct(col: "ColumnOrName", rsd: Optional[float] = None) -> C
A new Column object representing the approximate unique count.
See Also
- ----------
Review Comment:
Okay, I have closed this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org